>Well, if it is that easy, I can do it. Patch attached and applied.

bmomjian · bmomjian · commit 0059c4216c1e · 2001-09-06T20:43:39.000Z
> >> On Mon, 3 Sep 2001 22:01:17 -0500, you wrote: >> public boolean isWritable(int column) throws SQLException >> { >> return !isReadOnly(column); >> } Actually, I think this change has a consequence for this method in the same class: public boolean isDefinitelyWritable(int column) throws SQLException { return isWritable(column); } This is from the JDBC spec (http://java.sun.com/j2se/1.3/docs/api/java/sql/ResultSetMetaData.html): isReadOnly() - Indicates whether the designated column is definitely not writable. isWritable() - Indicates whether it is possible for a write on the designated column to succeed. isDefinitelyWritable() - Indicates whether a write on the designated column will definitely succeed. At this time we don't really implement the fine semantics of these methods. I would suggest the following defaults: isReadOnly() false isWritable() true isDefinitelyWritable() false And that would mean that your patch is correct, but isDefinitelyWritable() would need to be patched accordingly: public boolean isDefinitelyWritable(int column) throws SQLException { return false; } Again, both in jdbc1 and jdbc2. Regards, Ren? Pijlman <rene@lab.applinet.nl>
diff --git a/src/interfaces/jdbc/org/postgresql/jdbc1/ResultSetMetaData.java b/src/interfaces/jdbc/org/postgresql/jdbc1/ResultSetMetaData.java
@@ -434,7 +434,7 @@ public boolean isWritable(int column) throws SQLException
    */
   public boolean isDefinitelyWritable(int column) throws SQLException
   {
-    return isWritable(column);
+    return false;
   }
   
   // ********************************************************
diff --git a/src/interfaces/jdbc/org/postgresql/jdbc2/ResultSetMetaData.java b/src/interfaces/jdbc/org/postgresql/jdbc2/ResultSetMetaData.java
@@ -429,7 +429,7 @@ public boolean isWritable(int column) throws SQLException
    */
   public boolean isDefinitelyWritable(int column) throws SQLException
   {
-    return isWritable(column);
+    return false;
   }
   
   // ********************************************************

Original file line number	Diff line number	Diff line change
`@@ -434,7 +434,7 @@ public boolean isWritable(int column) throws SQLException`
`434`	`434`	`*/`
`435`	`435`	`public boolean isDefinitelyWritable(int column) throws SQLException`
`436`	`436`	`{`
`437`		`- return isWritable(column);`
	`437`	`+ return false;`
`438`	`438`	`}`
`439`	`439`
`440`	`440`	`// ********************************************************`
Original file line number	Diff line number	Diff line change
`@@ -429,7 +429,7 @@ public boolean isWritable(int column) throws SQLException`
`429`	`429`	`*/`
`430`	`430`	`public boolean isDefinitelyWritable(int column) throws SQLException`
`431`	`431`	`{`
`432`		`- return isWritable(column);`
	`432`	`+ return false;`
`433`	`433`	`}`
`434`	`434`
`435`	`435`	`// ********************************************************`