add some comments and fixme's

kelvich · kelvich · commit 1fa4feea625b · 2017-11-13T02:21:38.000+03:00
diff --git a/multimaster.c b/multimaster.c
@@ -2370,7 +2370,7 @@ static void MtmInitialize()
 		Mtm->nLiveNodes = 0; //MtmNodes;
 		Mtm->nAllNodes = MtmNodes;
 		Mtm->disabledNodeMask = 7; //XXXX
-		Mtm->clique = 7; // XXXX
+		Mtm->clique = 7; // XXXX ! should be inverted !
 		Mtm->stalledNodeMask = 0;
 		Mtm->stoppedNodeMask = 0;
 		Mtm->deadNodeMask = 0;
diff --git a/pglogical_receiver.c b/pglogical_receiver.c
@@ -366,8 +366,7 @@ pglogical_receiver_main(Datum main_arg)
 			}
 			if (n_deleted_slots == Mtm->nAllNodes - 1)
 			{
-				elog(WARNING, "All neighbour nopes have no replication slot for us. Exiting.");
-				kill(PostmasterPid, SIGTERM);
+				elog(FATAL, "All neighbour nopes have no replication slot for us. Exiting.");
 			}
 			proc_exit(1);
 		}
diff --git a/state.c b/state.c
@@ -143,7 +143,7 @@ MtmCheckState(void)
 
 
 void
-MtmStateProcessNeighborEvent(int node_id, MtmNeighborEvent ev)
+MtmStateProcessNeighborEvent(int node_id, MtmNeighborEvent ev) // XXXX camelcase node_id
 {
 	MTM_LOG1("[STATE] Node %i: %s", node_id, MtmNeighborEventMnem[ev]);
 
@@ -402,7 +402,7 @@ MtmRefreshClusterStatus()
 
 	if (newClique != trivialClique)
 	{
-		MTM_LOG1("[STATE] NONTRIVIAL CLIQUE!");
+		MTM_LOG1("[STATE] NONTRIVIAL CLIQUE! (trivial: %s)", maskToString(trivialClique, Mtm->nAllNodes)); // XXXX some false-positives, fixme
 	}
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -366,8 +366,7 @@ pglogical_receiver_main(Datum main_arg)`
`366`	`366`	`}`
`367`	`367`	`if (n_deleted_slots == Mtm->nAllNodes - 1)`
`368`	`368`	`{`
`369`		`- elog(WARNING, "All neighbour nopes have no replication slot for us. Exiting.");`
`370`		`- kill(PostmasterPid, SIGTERM);`
	`369`	`+ elog(FATAL, "All neighbour nopes have no replication slot for us. Exiting.");`
`371`	`370`	`}`
`372`	`371`	`proc_exit(1);`
`373`	`372`	`}`
Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ MtmCheckState(void)`
`143`	`143`
`144`	`144`
`145`	`145`	`void`
`146`		`-MtmStateProcessNeighborEvent(int node_id, MtmNeighborEvent ev)`
	`146`	`+MtmStateProcessNeighborEvent(int node_id, MtmNeighborEvent ev) // XXXX camelcase node_id`
`147`	`147`	`{`
`148`	`148`	`MTM_LOG1("[STATE] Node %i: %s", node_id, MtmNeighborEventMnem[ev]);`
`149`	`149`
`@@ -402,7 +402,7 @@ MtmRefreshClusterStatus()`
`402`	`402`
`403`	`403`	`if (newClique != trivialClique)`
`404`	`404`	`{`
`405`		`- MTM_LOG1("[STATE] NONTRIVIAL CLIQUE!");`
	`405`	`+ MTM_LOG1("[STATE] NONTRIVIAL CLIQUE! (trivial: %s)", maskToString(trivialClique, Mtm->nAllNodes)); // XXXX some false-positives, fixme`
`406`	`406`	`}`
`407`	`407`
`408`	`408`	`/*`