Skip to content

Commit 23bccc8

Browse files
committed
Fix inconsistencies and typos in the tree
This is numbered take 7, and addresses a set of issues with code comments, variable names and unreferenced variables. Author: Alexander Lakhin Discussion: https://postgr.es/m/dff75442-2468-f74f-568c-6006e141062f@gmail.com
1 parent e1a0f6a commit 23bccc8

File tree

44 files changed

+49
-65
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+49
-65
lines changed

contrib/jsonb_plperl/jsonb_plperlu--1.0.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* contrib/json_plperl/jsonb_plperl--1.0.sql */
1+
/* contrib/jsonb_plperl/jsonb_plperlu--1.0.sql */
22

33
-- complain if script is sourced in psql, rather than via CREATE EXTENSION
44
\echo Use "CREATE EXTENSION jsonb_plperlu" to load this file. \quit

contrib/pgcrypto/pgp-compress.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ pgp_decompress_filter(PullFilter **res, PGP_Context *ctx, PullFilter *src)
311311
{
312312
return pullf_create(res, &decompress_filter, ctx, src);
313313
}
314-
#else /* !HAVE_ZLIB */
314+
#else /* !HAVE_LIBZ */
315315

316316
int
317317
pgp_compress_filter(PushFilter **res, PGP_Context *ctx, PushFilter *dst)

doc/src/sgml/problems.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@
252252
C library, processor, memory information, and so on. In most
253253
cases it is sufficient to report the vendor and version, but do
254254
not assume everyone knows what exactly <quote>Debian</quote>
255-
contains or that everyone runs on i386s. If you have
255+
contains or that everyone runs on x86_64. If you have
256256
installation problems then information about the toolchain on
257257
your machine (compiler, <application>make</application>, and so
258258
on) is also necessary.

src/backend/access/common/reloptions.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
* currently executing.
7070
*
7171
* Fillfactor can be set because it applies only to subsequent changes made to
72-
* data blocks, as documented in heapio.c
72+
* data blocks, as documented in hio.c
7373
*
7474
* n_distinct options can be set at ShareUpdateExclusiveLock because they
7575
* are only used during ANALYZE, which uses a ShareUpdateExclusiveLock,

src/backend/access/gin/gindatapage.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ typedef struct
9292

9393
/*
9494
* The following fields represent the items in this segment. If 'items' is
95-
* not NULL, it contains a palloc'd array of the itemsin this segment. If
95+
* not NULL, it contains a palloc'd array of the items in this segment. If
9696
* 'seg' is not NULL, it contains the items in an already-compressed
9797
* format. It can point to an on-disk page (!modified), or a palloc'd
9898
* segment in memory. If both are set, they must represent the same items.

src/backend/access/gist/gistget.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -663,7 +663,7 @@ gistgettuple(IndexScanDesc scan, ScanDirection dir)
663663
}
664664

665665
/*
666-
* Check the last returned tuple and add it to killitems if
666+
* Check the last returned tuple and add it to killedItems if
667667
* necessary
668668
*/
669669
if (scan->kill_prior_tuple

src/backend/access/gist/gistutil.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ gistjoinvector(IndexTuple *itvec, int *len, IndexTuple *additvec, int addlen)
120120
}
121121

122122
/*
123-
* make plain IndexTupleVector
123+
* make plain IndexTuple vector
124124
*/
125125

126126
IndexTupleData *

src/backend/access/hash/hashovfl.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,7 @@ _hash_initbitmapbuffer(Buffer buf, uint16 bmsize, bool initpage)
793793
* be confused into returning the same tuple more than once or some tuples
794794
* not at all by the rearrangement we are performing here. To prevent
795795
* any concurrent scan to cross the squeeze scan we use lock chaining
796-
* similar to hasbucketcleanup. Refer comments atop hashbucketcleanup.
796+
* similar to hashbucketcleanup. Refer comments atop hashbucketcleanup.
797797
*
798798
* We need to retain a pin on the primary bucket to ensure that no concurrent
799799
* split can start.

src/backend/access/hash/hashpage.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ _hash_init_metabuffer(Buffer buf, double num_tuples, RegProcedure procid,
509509
* Choose the number of initial bucket pages to match the fill factor
510510
* given the estimated number of tuples. We round up the result to the
511511
* total number of buckets which has to be allocated before using its
512-
* _hashm_spare element. However always force at least 2 bucket pages. The
512+
* hashm_spares element. However always force at least 2 bucket pages. The
513513
* upper limit is determined by considerations explained in
514514
* _hash_expandtable().
515515
*/

src/backend/access/heap/heapam.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ static void MultiXactIdWait(MultiXactId multi, MultiXactStatus status, uint16 in
102102
static bool ConditionalMultiXactIdWait(MultiXactId multi, MultiXactStatus status,
103103
uint16 infomask, Relation rel, int *remaining);
104104
static XLogRecPtr log_heap_new_cid(Relation relation, HeapTuple tup);
105-
static HeapTuple ExtractReplicaIdentity(Relation rel, HeapTuple tup, bool key_modified,
105+
static HeapTuple ExtractReplicaIdentity(Relation rel, HeapTuple tup, bool key_changed,
106106
bool *copy);
107107

108108

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy