Update uniswap.py #408
Open
Update uniswap.py #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a ValueError exception caused by web3.py, when using self.w3.net.version it can return a hexadecimal number which needs to be handled differently than a regular integer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a ValueError exception caused by web3.py, when using
self.w3.net.versionit can return a hexadecimal number which needs to be handled differently than a regular integer.Basically,
will throw a ValueError because the number of the version is returned in hexadecimal format 0x1, which needs to be translated from base-16 instead of base-10 which is now properly handled by a try and catch clause.