Skip to content

fix: handle missing time in packument to prevent crash on npm view #8241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

owlstronaut
Copy link
Contributor

@owlstronaut owlstronaut commented Apr 18, 2025

fixes #8132

Before & After

image

Validated that tests start throwing errors without the fix ✅

@owlstronaut owlstronaut force-pushed the owlstronaut/fix-view-crash branch from b4ae395 to ebecc1d Compare April 18, 2025 15:59
@owlstronaut owlstronaut changed the title fix: gracefully handle missing time in packument to prevent crash on npm view fix: handle missing time in packument to prevent crash on npm view Apr 18, 2025
@owlstronaut owlstronaut marked this pull request as ready for review April 18, 2025 16:05
@owlstronaut owlstronaut requested a review from a team as a code owner April 18, 2025 16:05
@owlstronaut owlstronaut force-pushed the owlstronaut/fix-view-crash branch from ebecc1d to b48c40a Compare April 21, 2025 15:55
@wraithgar
Copy link
Member

Test failures are cause the source branch is behind by one commit. Tests for this PR are ok.

@owlstronaut owlstronaut merged commit 1622ac4 into latest Apr 21, 2025
14 of 38 checks passed
@owlstronaut owlstronaut deleted the owlstronaut/fix-view-crash branch April 21, 2025 16:07
@github-actions github-actions bot mentioned this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Npm view command issue when private registry return manifest short version
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy