Make sure walsender state is only read while holding the spinlock

mhagander · mhagander · commit 9eacd427e811 · 2011-01-13T18:51:13.000+01:00
Noted by Robert Haas.
diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
@@ -1050,6 +1050,7 @@ pg_stat_get_wal_senders(PG_FUNCTION_ARGS)
 		volatile WalSnd *walsnd = &WalSndCtl->walsnds[i];
 		char		sent_location[MAXFNAMELEN];
 		XLogRecPtr	sentPtr;
+		WalSndState	state;
 		Datum		values[PG_STAT_GET_WAL_SENDERS_COLS];
 		bool		nulls[PG_STAT_GET_WAL_SENDERS_COLS];
 
@@ -1058,14 +1059,15 @@ pg_stat_get_wal_senders(PG_FUNCTION_ARGS)
 
 		SpinLockAcquire(&walsnd->mutex);
 		sentPtr = walsnd->sentPtr;
+		state = walsnd->state;
 		SpinLockRelease(&walsnd->mutex);
 
 		snprintf(sent_location, sizeof(sent_location), "%X/%X",
 					sentPtr.xlogid, sentPtr.xrecoff);
 
 		memset(nulls, 0, sizeof(nulls));
 		values[0] = Int32GetDatum(walsnd->pid);
-		values[1] = CStringGetTextDatum(WalSndGetStateString(walsnd->state));
+		values[1] = CStringGetTextDatum(WalSndGetStateString(state));
 		values[2] = CStringGetTextDatum(sent_location);
 
 		tuplestore_putvalues(tupstore, tupdesc, values, nulls);
