From 2e83877200fa35e7a7a577b05675ddae97062f29 Mon Sep 17 00:00:00 2001
From: alxkm <alexanderklmn@gmail.com>
Date: Wed, 16 Jul 2025 21:40:28 +0200
Subject: [PATCH 1/3] testing: improving test coverage DisjointSetUnionTest

---
 .../DisjointSetUnionTest.java                 | 106 +++++++++++++++---
 1 file changed, 92 insertions(+), 14 deletions(-)

diff --git a/src/test/java/com/thealgorithms/datastructures/disjointsetunion/DisjointSetUnionTest.java b/src/test/java/com/thealgorithms/datastructures/disjointsetunion/DisjointSetUnionTest.java
index a10a99d40496..1366435c1c84 100644
--- a/src/test/java/com/thealgorithms/datastructures/disjointsetunion/DisjointSetUnionTest.java
+++ b/src/test/java/com/thealgorithms/datastructures/disjointsetunion/DisjointSetUnionTest.java
@@ -1,8 +1,9 @@
 package com.thealgorithms.datastructures.disjointsetunion;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 
-import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
 public class DisjointSetUnionTest {
@@ -12,7 +13,7 @@ public void testMakeSet() {
         DisjointSetUnion<Integer> dsu = new DisjointSetUnion<>();
         Node<Integer> node = dsu.makeSet(1);
         assertNotNull(node);
-        Assertions.assertEquals(node, node.parent);
+        assertEquals(node, node.parent);
     }
 
     @Test
@@ -33,19 +34,96 @@ public void testUnionFindSet() {
         Node<Integer> root3 = dsu.findSet(node3);
         Node<Integer> root4 = dsu.findSet(node4);
 
-        Assertions.assertEquals(node1, node1.parent);
-        Assertions.assertEquals(node1, node2.parent);
-        Assertions.assertEquals(node1, node3.parent);
-        Assertions.assertEquals(node1, node4.parent);
+        assertEquals(node1, node1.parent);
+        assertEquals(node1, node2.parent);
+        assertEquals(node1, node3.parent);
+        assertEquals(node1, node4.parent);
 
-        Assertions.assertEquals(node1, root1);
-        Assertions.assertEquals(node1, root2);
-        Assertions.assertEquals(node1, root3);
-        Assertions.assertEquals(node1, root4);
+        assertEquals(node1, root1);
+        assertEquals(node1, root2);
+        assertEquals(node1, root3);
+        assertEquals(node1, root4);
 
-        Assertions.assertEquals(1, node1.rank);
-        Assertions.assertEquals(0, node2.rank);
-        Assertions.assertEquals(0, node3.rank);
-        Assertions.assertEquals(0, node4.rank);
+        assertEquals(1, node1.rank);
+        assertEquals(0, node2.rank);
+        assertEquals(0, node3.rank);
+        assertEquals(0, node4.rank);
+    }
+
+    @Test
+    public void testFindSetOnSingleNode() {
+        DisjointSetUnion<String> dsu = new DisjointSetUnion<>();
+        Node<String> node = dsu.makeSet("A");
+        assertEquals(node, dsu.findSet(node));
+    }
+
+    @Test
+    public void testUnionAlreadyConnectedNodes() {
+        DisjointSetUnion<Integer> dsu = new DisjointSetUnion<>();
+        Node<Integer> node1 = dsu.makeSet(1);
+        Node<Integer> node2 = dsu.makeSet(2);
+        Node<Integer> node3 = dsu.makeSet(3);
+
+        dsu.unionSets(node1, node2);
+        dsu.unionSets(node2, node3);
+
+        // Union nodes that are already connected
+        dsu.unionSets(node1, node3);
+
+        // All should have the same root
+        Node<Integer> root = dsu.findSet(node1);
+        assertEquals(root, dsu.findSet(node2));
+        assertEquals(root, dsu.findSet(node3));
+    }
+
+    @Test
+    public void testRankIncrease() {
+        DisjointSetUnion<Integer> dsu = new DisjointSetUnion<>();
+        Node<Integer> node1 = dsu.makeSet(1);
+        Node<Integer> node2 = dsu.makeSet(2);
+        Node<Integer> node3 = dsu.makeSet(3);
+        Node<Integer> node4 = dsu.makeSet(4);
+
+        dsu.unionSets(node1, node2); // rank of node1 should increase
+        dsu.unionSets(node3, node4); // rank of node3 should increase
+        dsu.unionSets(node1, node3); // union two trees of same rank -> rank increases
+
+        assertEquals(2, dsu.findSet(node1).rank);
+    }
+
+    @Test
+    public void testMultipleMakeSets() {
+        DisjointSetUnion<Integer> dsu = new DisjointSetUnion<>();
+        Node<Integer> node1 = dsu.makeSet(1);
+        Node<Integer> node2 = dsu.makeSet(2);
+        Node<Integer> node3 = dsu.makeSet(3);
+
+        assertNotEquals(node1, node2);
+        assertNotEquals(node2, node3);
+        assertNotEquals(node1, node3);
+
+        assertEquals(node1, node1.parent);
+        assertEquals(node2, node2.parent);
+        assertEquals(node3, node3.parent);
+    }
+
+    @Test
+    public void testPathCompression() {
+        DisjointSetUnion<Integer> dsu = new DisjointSetUnion<>();
+        Node<Integer> node1 = dsu.makeSet(1);
+        Node<Integer> node2 = dsu.makeSet(2);
+        Node<Integer> node3 = dsu.makeSet(3);
+
+        dsu.unionSets(node1, node2);
+        dsu.unionSets(node2, node3);
+
+        // Before path compression, parent of node3 might not be node1 directly
+        Node<Integer> parentBefore = node3.parent;
+
+        // After findSet, path compression should update parent to root directly
+        Node<Integer> root = dsu.findSet(node3);
+        assertEquals(root, node1);
+        assertEquals(node1, node3.parent);
+        //assertNotEquals(parentBefore, node3.parent);
     }
 }

From 306b4dff9f74f9e06a15c5015bbdc07fb642f1e6 Mon Sep 17 00:00:00 2001
From: alxkm <alexanderklmn@gmail.com>
Date: Wed, 16 Jul 2025 21:43:19 +0200
Subject: [PATCH 2/3] style: remove redundant comment

---
 .../datastructures/disjointsetunion/DisjointSetUnionTest.java    | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/test/java/com/thealgorithms/datastructures/disjointsetunion/DisjointSetUnionTest.java b/src/test/java/com/thealgorithms/datastructures/disjointsetunion/DisjointSetUnionTest.java
index 1366435c1c84..0c105a760e80 100644
--- a/src/test/java/com/thealgorithms/datastructures/disjointsetunion/DisjointSetUnionTest.java
+++ b/src/test/java/com/thealgorithms/datastructures/disjointsetunion/DisjointSetUnionTest.java
@@ -124,6 +124,5 @@ public void testPathCompression() {
         Node<Integer> root = dsu.findSet(node3);
         assertEquals(root, node1);
         assertEquals(node1, node3.parent);
-        //assertNotEquals(parentBefore, node3.parent);
     }
 }

From 52dc52d4b2455d5636ddbc072958f2bac5afc7e2 Mon Sep 17 00:00:00 2001
From: alxkm <alexanderklmn@gmail.com>
Date: Fri, 18 Jul 2025 22:55:25 +0200
Subject: [PATCH 3/3] testing: removing unused variable

---
 .../datastructures/disjointsetunion/DisjointSetUnionTest.java  | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/test/java/com/thealgorithms/datastructures/disjointsetunion/DisjointSetUnionTest.java b/src/test/java/com/thealgorithms/datastructures/disjointsetunion/DisjointSetUnionTest.java
index 0c105a760e80..14dceb53c40d 100644
--- a/src/test/java/com/thealgorithms/datastructures/disjointsetunion/DisjointSetUnionTest.java
+++ b/src/test/java/com/thealgorithms/datastructures/disjointsetunion/DisjointSetUnionTest.java
@@ -117,9 +117,6 @@ public void testPathCompression() {
         dsu.unionSets(node1, node2);
         dsu.unionSets(node2, node3);
 
-        // Before path compression, parent of node3 might not be node1 directly
-        Node<Integer> parentBefore = node3.parent;
-
         // After findSet, path compression should update parent to root directly
         Node<Integer> root = dsu.findSet(node3);
         assertEquals(root, node1);

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>pFad - Phonifier reborn</title>
<meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
</head>
<body>
<h1>Pfad - The Proxy pFad of &#169; 2024 Garber Painting. All rights reserved.</h1>


<!-- Disclaimer -->
<p>Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.</p>
<br>
<p>Alternative Proxies:</p><p><a href="http://rainy.clevelandohioweatherforecast.com/php-proxy/index.php?q=https://patch-diff.githubusercontent.com/raw/TheAlgorithms/Java/pull/6394.patch" target="_blank">Alternative Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/index.php?u=https://patch-diff.githubusercontent.com/raw/TheAlgorithms/Java/pull/6394.patch" target="_blank">pFad Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v3index.php?u=https://patch-diff.githubusercontent.com/raw/TheAlgorithms/Java/pull/6394.patch" target="_blank">pFad v3 Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v4index.php?u=https://patch-diff.githubusercontent.com/raw/TheAlgorithms/Java/pull/6394.patch" target="_blank">pFad v4 Proxy</a></p></body>
</html>