From 7dc05ccd110ae2f0395de62dac06c5edb4acdaab Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Mon, 3 Mar 2025 15:57:17 +0000 Subject: [PATCH] feat: enable agent connection reports by default, remove flag --- agent/agent.go | 8 -------- agent/agent_test.go | 23 +++++------------------ cli/agent.go | 14 -------------- 3 files changed, 5 insertions(+), 40 deletions(-) diff --git a/agent/agent.go b/agent/agent.go index c42bf3a815e18..acd959582280f 100644 --- a/agent/agent.go +++ b/agent/agent.go @@ -91,7 +91,6 @@ type Options struct { Execer agentexec.Execer ContainerLister agentcontainers.Lister - ExperimentalConnectionReports bool ExperimentalDevcontainersEnabled bool } @@ -196,7 +195,6 @@ func New(options Options) Agent { lister: options.ContainerLister, experimentalDevcontainersEnabled: options.ExperimentalDevcontainersEnabled, - experimentalConnectionReports: options.ExperimentalConnectionReports, } // Initially, we have a closed channel, reflecting the fact that we are not initially connected. // Each time we connect we replace the channel (while holding the closeMutex) with a new one @@ -273,7 +271,6 @@ type agent struct { lister agentcontainers.Lister experimentalDevcontainersEnabled bool - experimentalConnectionReports bool } func (a *agent) TailnetConn() *tailnet.Conn { @@ -797,11 +794,6 @@ const ( ) func (a *agent) reportConnection(id uuid.UUID, connectionType proto.Connection_Type, ip string) (disconnected func(code int, reason string)) { - // If the experiment hasn't been enabled, we don't report connections. - if !a.experimentalConnectionReports { - return func(int, string) {} // Noop. - } - // Remove the port from the IP because ports are not supported in coderd. if host, _, err := net.SplitHostPort(ip); err != nil { a.logger.Error(a.hardCtx, "split host and port for connection report failed", slog.F("ip", ip), slog.Error(err)) diff --git a/agent/agent_test.go b/agent/agent_test.go index 44112b6524fc9..d6c8e4d97644c 100644 --- a/agent/agent_test.go +++ b/agent/agent_test.go @@ -173,9 +173,7 @@ func TestAgent_Stats_Magic(t *testing.T) { ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong) defer cancel() //nolint:dogsled - conn, agentClient, stats, _, _ := setupAgent(t, agentsdk.Manifest{}, 0, func(_ *agenttest.Client, o *agent.Options) { - o.ExperimentalConnectionReports = true - }) + conn, agentClient, stats, _, _ := setupAgent(t, agentsdk.Manifest{}, 0) sshClient, err := conn.SSHClient(ctx) require.NoError(t, err) defer sshClient.Close() @@ -243,9 +241,7 @@ func TestAgent_Stats_Magic(t *testing.T) { remotePort := sc.Text() //nolint:dogsled - conn, agentClient, stats, _, _ := setupAgent(t, agentsdk.Manifest{}, 0, func(_ *agenttest.Client, o *agent.Options) { - o.ExperimentalConnectionReports = true - }) + conn, agentClient, stats, _, _ := setupAgent(t, agentsdk.Manifest{}, 0) sshClient, err := conn.SSHClient(ctx) require.NoError(t, err) @@ -960,9 +956,7 @@ func TestAgent_SFTP(t *testing.T) { home = "/" + strings.ReplaceAll(home, "\\", "/") } //nolint:dogsled - conn, agentClient, _, _, _ := setupAgent(t, agentsdk.Manifest{}, 0, func(_ *agenttest.Client, o *agent.Options) { - o.ExperimentalConnectionReports = true - }) + conn, agentClient, _, _, _ := setupAgent(t, agentsdk.Manifest{}, 0) sshClient, err := conn.SSHClient(ctx) require.NoError(t, err) defer sshClient.Close() @@ -998,9 +992,7 @@ func TestAgent_SCP(t *testing.T) { defer cancel() //nolint:dogsled - conn, agentClient, _, _, _ := setupAgent(t, agentsdk.Manifest{}, 0, func(_ *agenttest.Client, o *agent.Options) { - o.ExperimentalConnectionReports = true - }) + conn, agentClient, _, _, _ := setupAgent(t, agentsdk.Manifest{}, 0) sshClient, err := conn.SSHClient(ctx) require.NoError(t, err) defer sshClient.Close() @@ -1043,7 +1035,6 @@ func TestAgent_FileTransferBlocked(t *testing.T) { //nolint:dogsled conn, agentClient, _, _, _ := setupAgent(t, agentsdk.Manifest{}, 0, func(_ *agenttest.Client, o *agent.Options) { o.BlockFileTransfer = true - o.ExperimentalConnectionReports = true }) sshClient, err := conn.SSHClient(ctx) require.NoError(t, err) @@ -1064,7 +1055,6 @@ func TestAgent_FileTransferBlocked(t *testing.T) { //nolint:dogsled conn, agentClient, _, _, _ := setupAgent(t, agentsdk.Manifest{}, 0, func(_ *agenttest.Client, o *agent.Options) { o.BlockFileTransfer = true - o.ExperimentalConnectionReports = true }) sshClient, err := conn.SSHClient(ctx) require.NoError(t, err) @@ -1093,7 +1083,6 @@ func TestAgent_FileTransferBlocked(t *testing.T) { //nolint:dogsled conn, agentClient, _, _, _ := setupAgent(t, agentsdk.Manifest{}, 0, func(_ *agenttest.Client, o *agent.Options) { o.BlockFileTransfer = true - o.ExperimentalConnectionReports = true }) sshClient, err := conn.SSHClient(ctx) require.NoError(t, err) @@ -1724,9 +1713,7 @@ func TestAgent_ReconnectingPTY(t *testing.T) { defer cancel() //nolint:dogsled - conn, agentClient, _, _, _ := setupAgent(t, agentsdk.Manifest{}, 0, func(_ *agenttest.Client, o *agent.Options) { - o.ExperimentalConnectionReports = true - }) + conn, agentClient, _, _, _ := setupAgent(t, agentsdk.Manifest{}, 0) id := uuid.New() // Test that the connection is reported. This must be tested in the diff --git a/cli/agent.go b/cli/agent.go index 5466ba9a5bc67..0a9031aed57c1 100644 --- a/cli/agent.go +++ b/cli/agent.go @@ -54,7 +54,6 @@ func (r *RootCmd) workspaceAgent() *serpent.Command { agentHeaderCommand string agentHeader []string - experimentalConnectionReports bool experimentalDevcontainersEnabled bool ) cmd := &serpent.Command{ @@ -327,10 +326,6 @@ func (r *RootCmd) workspaceAgent() *serpent.Command { containerLister = agentcontainers.NewDocker(execer) } - if experimentalConnectionReports { - logger.Info(ctx, "experimental connection reports enabled") - } - agnt := agent.New(agent.Options{ Client: client, Logger: logger, @@ -359,7 +354,6 @@ func (r *RootCmd) workspaceAgent() *serpent.Command { ContainerLister: containerLister, ExperimentalDevcontainersEnabled: experimentalDevcontainersEnabled, - ExperimentalConnectionReports: experimentalConnectionReports, }) promHandler := agent.PrometheusMetricsHandler(prometheusRegistry, logger) @@ -489,14 +483,6 @@ func (r *RootCmd) workspaceAgent() *serpent.Command { Description: "Allow the agent to automatically detect running devcontainers.", Value: serpent.BoolOf(&experimentalDevcontainersEnabled), }, - { - Flag: "experimental-connection-reports-enable", - Hidden: true, - Default: "false", - Env: "CODER_AGENT_EXPERIMENTAL_CONNECTION_REPORTS_ENABLE", - Description: "Enable experimental connection reports.", - Value: serpent.BoolOf(&experimentalConnectionReports), - }, } return cmd pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy