From f6283ed54b952150f75e6d6f9af5036b88e9837e Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Mon, 10 Mar 2025 12:45:37 +0100 Subject: [PATCH 1/2] skip: daylight savings issues --- coderd/database/querier_test.go | 2 ++ coderd/insights_internal_test.go | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/coderd/database/querier_test.go b/coderd/database/querier_test.go index 2eb3125fc25af..7b67d81f7f4fc 100644 --- a/coderd/database/querier_test.go +++ b/coderd/database/querier_test.go @@ -3301,6 +3301,8 @@ func TestGetUserStatusCounts(t *testing.T) { t.Run("User deleted during query range", func(t *testing.T) { t.Parallel() + t.Skip("https://github.com/coder/internal/issues/464") + db, _ := dbtestutil.NewDB(t) ctx := testutil.Context(t, testutil.WaitShort) diff --git a/coderd/insights_internal_test.go b/coderd/insights_internal_test.go index bfd93b6f687b8..111bd268e8855 100644 --- a/coderd/insights_internal_test.go +++ b/coderd/insights_internal_test.go @@ -226,6 +226,7 @@ func Test_parseInsightsInterval_week(t *testing.T) { }, wantOk: true, }, + /* FIXME: daylight savings issue { name: "6 days are acceptable", args: args{ @@ -233,7 +234,7 @@ func Test_parseInsightsInterval_week(t *testing.T) { endTime: stripTime(thisHour).Format(layout), }, wantOk: true, - }, + },*/ { name: "Shorter than a full week", args: args{ From 39a4c5c76f95bc88943294aa3274681d06575b4f Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Mon, 10 Mar 2025 12:56:13 +0100 Subject: [PATCH 2/2] fix --- coderd/database/querier_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/coderd/database/querier_test.go b/coderd/database/querier_test.go index 7b67d81f7f4fc..837068f1fa03e 100644 --- a/coderd/database/querier_test.go +++ b/coderd/database/querier_test.go @@ -2802,6 +2802,7 @@ func TestGroupRemovalTrigger(t *testing.T) { func TestGetUserStatusCounts(t *testing.T) { t.Parallel() + t.Skip("https://github.com/coder/internal/issues/464") if !dbtestutil.WillUsePostgres() { t.SkipNow() @@ -3301,7 +3302,6 @@ func TestGetUserStatusCounts(t *testing.T) { t.Run("User deleted during query range", func(t *testing.T) { t.Parallel() - t.Skip("https://github.com/coder/internal/issues/464") db, _ := dbtestutil.NewDB(t) ctx := testutil.Context(t, testutil.WaitShort) pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy