From a27a8f0872dd123d856c3ec0c565ff4c38424da2 Mon Sep 17 00:00:00 2001 From: BrunoQuaresma Date: Wed, 12 Mar 2025 13:57:42 +0000 Subject: [PATCH] refactor: name null users in audit logs --- .../AuditLogDescription/AuditLogDescription.stories.tsx | 9 +++++++++ .../AuditLogDescription/AuditLogDescription.tsx | 4 +++- .../AuditLogDescription/BuildAuditDescription.tsx | 4 +++- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/AuditLogDescription.stories.tsx b/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/AuditLogDescription.stories.tsx index dd2c88f5be50b..99d4f900ca0d6 100644 --- a/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/AuditLogDescription.stories.tsx +++ b/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/AuditLogDescription.stories.tsx @@ -105,3 +105,12 @@ export const SCIMUpdateUser: Story = { }, }, }; + +export const UnauthenticatedUser: Story = { + args: { + auditLog: { + ...MockAuditLog, + user: null, + }, + }, +}; diff --git a/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/AuditLogDescription.tsx b/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/AuditLogDescription.tsx index 4b2a9b4df4df7..ed105989f1f02 100644 --- a/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/AuditLogDescription.tsx +++ b/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/AuditLogDescription.tsx @@ -19,7 +19,9 @@ export const AuditLogDescription: FC = ({ } let target = auditLog.resource_target.trim(); - let user = auditLog.user?.username.trim(); + let user = auditLog.user + ? auditLog.user.username.trim() + : "Unauthenticated user"; // SSH key entries have no links if (auditLog.resource_type === "git_ssh_key") { diff --git a/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/BuildAuditDescription.tsx b/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/BuildAuditDescription.tsx index ca610eb01f6a3..8e321d6e85334 100644 --- a/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/BuildAuditDescription.tsx +++ b/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/BuildAuditDescription.tsx @@ -16,7 +16,9 @@ export const BuildAuditDescription: FC = ({ auditLog.additional_fields?.build_reason && auditLog.additional_fields?.build_reason !== "initiator" ? "Coder automatically" - : auditLog.user?.username.trim(); + : auditLog.user + ? auditLog.user.username.trim() + : "Unauthenticated user"; const action = useMemo(() => { switch (auditLog.action) { pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy