From 3137464ef17b58246f5d02d733ab1cbad9173746 Mon Sep 17 00:00:00 2001 From: zhuzi Date: Tue, 15 Nov 2016 11:03:53 +0800 Subject: [PATCH] add options param to listIssueComments so that it can get pagination support --- lib/Issue.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/Issue.js b/lib/Issue.js index 07fa2b1a..d7118083 100644 --- a/lib/Issue.js +++ b/lib/Issue.js @@ -59,11 +59,12 @@ class Issue extends Requestable { * List comments on an issue * @see https://developer.github.com/v3/issues/comments/#list-comments-on-an-issue * @param {number} issue - the id of the issue to get comments from + * @param {Object} options - pagination options, per_page & page * @param {Requestable.callback} [cb] - will receive the comments * @return {Promise} - the promise for the http request */ - listIssueComments(issue, cb) { - return this._request('GET', `/repos/${this.__repository}/issues/${issue}/comments`, null, cb); + listIssueComments(issue, options, cb) { + return this._request('GET', `/repos/${this.__repository}/issues/${issue}/comments`, options, cb); } /** pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy