From 4bd827e66abff6779c5bfeb48c8cd89c1b00a922 Mon Sep 17 00:00:00 2001 From: Matt Smith Date: Fri, 18 Nov 2016 08:20:58 -0700 Subject: [PATCH 1/3] chore: Fix linting error --- lib/Repository.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/Repository.js b/lib/Repository.js index 301e1230..7204805f 100644 --- a/lib/Repository.js +++ b/lib/Repository.js @@ -504,7 +504,8 @@ class Repository extends Requestable { * @return {Promise} - the promise for the http request */ updatePullRequst(number, options, cb) { - log('Deprecated: This method contains a typo and it has been deprecated. It will be removed in next major version. Use updatePullRequest() instead.'); + log('Deprecated: This method contains a typo and it has been deprecated. It will be removed in next major ' + + 'version. Use updatePullRequest() instead.'); return this.updatePullRequest(number, options, cb); } From e5bda4f2c67eaf6d8c58e693b1239bf6c695a950 Mon Sep 17 00:00:00 2001 From: Matt Smith Date: Fri, 18 Nov 2016 08:40:37 -0700 Subject: [PATCH 2/3] chore: Move Mocha opts to test folder This will allow you to run `mocha -w` without any other special arguments and still get babel compilation --- package.json | 2 +- mocha.opts => test/mocha.opts | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename mocha.opts => test/mocha.opts (100%) diff --git a/package.json b/package.json index c942525d..8bdcae5b 100644 --- a/package.json +++ b/package.json @@ -14,7 +14,7 @@ "scripts": { "clean": "gulp clean", "build": "gulp build", - "test": "mocha --opts ./mocha.opts test/*.spec.js", + "test": "mocha", "test-verbose": "DEBUG=github* npm test", "lint": "gulp lint", "make-docs": "node_modules/.bin/jsdoc -c .jsdoc.json --verbose", diff --git a/mocha.opts b/test/mocha.opts similarity index 100% rename from mocha.opts rename to test/mocha.opts From ea3866302397c6ce63cb682f11b1d9be6c928781 Mon Sep 17 00:00:00 2001 From: Matt Smith Date: Fri, 18 Nov 2016 12:57:07 -0700 Subject: [PATCH 3/3] chore: Move variable scope as this was causing the mikedeboertest/TestRepo to get deleted. --- test/repository.spec.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/repository.spec.js b/test/repository.spec.js index f747878d..8e709255 100644 --- a/test/repository.spec.js +++ b/test/repository.spec.js @@ -8,7 +8,6 @@ import getTestRepoName from './helpers/getTestRepoName'; describe('Repository', function() { let github; - let remoteRepo; let user; let imageB64; let imageBlob; @@ -30,6 +29,8 @@ describe('Repository', function() { }); describe('reading', function() { + let remoteRepo; + before(function() { remoteRepo = github.getRepo('michael', 'github'); }); @@ -265,6 +266,7 @@ describe('Repository', function() { const releaseBody = 'This is my 49 character long release description.'; let sha; let releaseId; + let remoteRepo; before(function() { user = github.getUser(); @@ -592,6 +594,8 @@ describe('Repository', function() { }); describe('deleting', function() { + let remoteRepo; + before(function() { remoteRepo = github.getRepo(testUser.USERNAME, testRepoName); }); pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy