From 234cb0d420b21e239593922f2e09d5f9ee15fa92 Mon Sep 17 00:00:00 2001 From: Mathew Liew Date: Sat, 5 Jan 2019 11:41:02 -0600 Subject: [PATCH] feat: Add 'use' tag of SVG to 'transformAssetUrls' option as default --- README.md | 1 + lib/templateCompilerModules/assetUrl.ts | 3 ++- test/compileTemplate.spec.ts | 22 +++++++++++++++------- 3 files changed, 18 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 0be4f4e..a3205b4 100644 --- a/README.md +++ b/README.md @@ -81,6 +81,7 @@ interface TemplateCompileOptions { // source: 'src', // img: 'src', // image: 'xlink:href' + // use: 'xlink:href' // } transformAssetUrls?: AssetURLOptions | boolean diff --git a/lib/templateCompilerModules/assetUrl.ts b/lib/templateCompilerModules/assetUrl.ts index b74b059..8838748 100644 --- a/lib/templateCompilerModules/assetUrl.ts +++ b/lib/templateCompilerModules/assetUrl.ts @@ -10,7 +10,8 @@ const defaultOptions: AssetURLOptions = { video: ['src', 'poster'], source: 'src', img: 'src', - image: ['xlink:href', 'href'] + image: ['xlink:href', 'href'], + use: ['xlink:href', 'href'] } export default (userOptions?: AssetURLOptions) => { diff --git a/test/compileTemplate.spec.ts b/test/compileTemplate.spec.ts index ccd52b4..bc1ef6d 100644 --- a/test/compileTemplate.spec.ts +++ b/test/compileTemplate.spec.ts @@ -152,6 +152,10 @@ test('transform srcset', () => { + +

@@ -183,16 +187,20 @@ test('transform srcset', () => { expect(vnode.children[2].children[0].data.attrs['xlink:href']).toBe( 'test-url' ) + // use tag (SVG) + expect(vnode.children[4].children[0].data.attrs['xlink:href']).toBe( + 'test-url' + ) // image tag with srcset - expect(vnode.children[4].data.attrs.srcset).toBe('test-url') - expect(vnode.children[6].data.attrs.srcset).toBe('test-url 2x') + expect(vnode.children[6].data.attrs.srcset).toBe('test-url') + expect(vnode.children[8].data.attrs.srcset).toBe('test-url 2x') // image tag with multiline srcset - expect(vnode.children[8].data.attrs.srcset).toBe('test-url, test-url 2x') - expect(vnode.children[10].data.attrs.srcset).toBe('test-url 2x, test-url') - expect(vnode.children[12].data.attrs.srcset).toBe('test-url 2x, test-url 3x') - expect(vnode.children[14].data.attrs.srcset).toBe( + expect(vnode.children[10].data.attrs.srcset).toBe('test-url, test-url 2x') + expect(vnode.children[12].data.attrs.srcset).toBe('test-url 2x, test-url') + expect(vnode.children[14].data.attrs.srcset).toBe('test-url 2x, test-url 3x') + expect(vnode.children[16].data.attrs.srcset).toBe( 'test-url, test-url 2x, test-url 3x' ) - expect(vnode.children[16].data.attrs.srcset).toBe('test-url 2x, test-url 3x') + expect(vnode.children[18].data.attrs.srcset).toBe('test-url 2x, test-url 3x') }) pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies: