Add transform support for the "regexp unicode sets" proposal #14125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50680/ |
nicolo-ribaudo
commented
Jan 8, 2022
| @@ -1,2 +1,2 @@ | |||
| var a = /[\u3400-\u4DBF\u4E00-\u9FFF\uFA0E\uFA0F\uFA11\uFA13\uFA14\uFA1F\uFA21\uFA23\uFA24\uFA27-\uFA29\u{20000}-\u{2A6DF}\u{2A700}-\u{2B738}\u{2B740}-\u{2B81D}\u{2B820}-\u{2CEA1}\u{2CEB0}-\u{2EBE0}\u{30000}-\u{3134A}][\0-\t\x0B\f\x0E-\u2027\u202A-\u{10FFFF}]/u; | |||
| var b = /[\u3400-\u4DBF\u4E00-\u9FFF\uFA0E\uFA0F\uFA11\uFA13\uFA14\uFA1F\uFA21\uFA23\uFA24\uFA27-\uFA29\u{20000}-\u{2A6DF}\u{2A700}-\u{2B738}\u{2B740}-\u{2B81D}\u{2B820}-\u{2CEA1}\u{2CEB0}-\u{2EBE0}\u{30000}-\u{3134A}][\0-\u{10FFFF}]/u; | |||
| var a = /[\u3400-\u4DBF\u4E00-\u9FFF\uFA0E\uFA0F\uFA11\uFA13\uFA14\uFA1F\uFA21\uFA23\uFA24\uFA27-\uFA29\u{20000}-\u{2A6DF}\u{2A700}-\u{2B738}\u{2B740}-\u{2B81D}\u{2B820}-\u{2CEA1}\u{2CEB0}-\u{2EBE0}\u{30000}-\u{3134A}]./u; | |||
There was a problem hiding this comment.
This looks like a regression, let me check.
There was a problem hiding this comment.
Oh actually, it's correct. The input code is
var a = /\p{Unified_Ideograph}./u;
var b = /\p{Unified_Ideograph}./su;regexpu-core
2 tasks
5912e33 to
82a69f2
Compare
mathiasbynens
approved these changes
Jan 10, 2022
9 tasks
|
I opened mathiasbynens/regexpu-core#56 for the CI failure. |
JLHwung
approved these changes
Jan 10, 2022
| dotAllFlag: feat("dotAllFlag"), | ||
| unicodePropertyEscapes: feat("unicodePropertyEscape"), | ||
| namedGroups: feat("namedCaptureGroups"), | ||
| unicodeFlag: feat<Stable>("unicodeFlag"), |
There was a problem hiding this comment.
nit: Since most flags are stable, we can use Experimental = 1 in type notations.
nicolo-ribaudo
added a commit
that referenced
this pull request
Jan 18, 2022
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two commits can be reviewed one by one.
(cc @mathiasbynens)