Skip to content

Update to use repo specific napi instead of npx #30914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 3, 2021
Merged

Update to use repo specific napi instead of npx #30914

merged 8 commits into from
Nov 3, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 3, 2021

This updates the napi-rs/cli invoking to not use npx similar to how swc does it and updates the version we have in our devDependencies

x-ref: https://github.com/vercel/next.js/runs/4097822944?check_suite_focus=true

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Nov 3, 2021
styfle
styfle previously approved these changes Nov 3, 2021
View reviewed changes
padmaia
padmaia reviewed Nov 3, 2021
View reviewed changes
padmaia
padmaia previously approved these changes Nov 3, 2021
View reviewed changes
@ijjk ijjk dismissed stale reviews from padmaia and styfle via 2da9c91 November 3, 2021 20:51
padmaia
padmaia previously approved these changes Nov 3, 2021
View reviewed changes
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Nov 3, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/napi-cli-invoking Change
buildDuration 18s 18.3s ⚠️ +236ms
buildDurationCached 3.8s 3.8s ⚠️ +34ms
nodeModulesSize 293 MB 293 MB -18 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/napi-cli-invoking Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.941 2.948 ⚠️ +0.01
/ avg req/sec 849.94 847.98 ⚠️ -1.96
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.388 1.427 ⚠️ +0.04
/error-in-render avg req/sec 1800.81 1751.96 ⚠️ -48.85
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/napi-cli-invoking Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28 kB 28 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 71.9 kB 71.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/napi-cli-invoking Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/napi-cli-invoking Change
_app-HASH.js gzip 1.23 kB 1.23 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.44 kB 4.44 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/napi-cli-invoking Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/napi-cli-invoking Change
index.html gzip 523 B 523 B ✓
link.html gzip 535 B 535 B ✓
withRouter.html gzip 516 B 516 B ✓
Overall change 1.57 kB 1.57 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/napi-cli-invoking Change
buildDuration 19.7s 19.7s ⚠️ +83ms
buildDurationCached 3.9s 3.8s -14ms
nodeModulesSize 293 MB 293 MB -18 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/napi-cli-invoking Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.923 2.949 ⚠️ +0.03
/ avg req/sec 855.19 847.65 ⚠️ -7.54
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.376 1.371 0
/error-in-render avg req/sec 1816.71 1823.73 +7.02
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/napi-cli-invoking Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.2 kB 28.2 kB ✓
webpack-HASH.js gzip 1.43 kB 1.43 kB ✓
Overall change 72.1 kB 72.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/napi-cli-invoking Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/napi-cli-invoking Change
_app-HASH.js gzip 1.22 kB 1.22 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 622 B 622 B ✓
image-HASH.js gzip 4.46 kB 4.46 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.91 kB 1.91 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/napi-cli-invoking Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/napi-cli-invoking Change
index.html gzip 521 B 521 B ✓
link.html gzip 534 B 534 B ✓
withRouter.html gzip 515 B 515 B ✓
Overall change 1.57 kB 1.57 kB ✓
Commit: 00d4e9d

@ijjk
Copy link
Member Author

ijjk commented Nov 3, 2021

Test build succeeded here https://github.com/vercel/next.js/runs/4098273191?check_suite_focus=true 🎉

@ijjk ijjk requested review from styfle and padmaia November 3, 2021 21:48
@ijjk ijjk merged commit a3a5926 into vercel:canary Nov 3, 2021
@ijjk ijjk deleted the update/napi-cli-invoking branch November 3, 2021 21:58
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

@padmaia padmaia Awaiting requested review from padmaia

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijjk @styfle @padmaia
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy