Skip to content

feat(eslint): allow a for internal url when target="blank" present #32780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 25, 2021
Merged

feat(eslint): allow a for internal url when target="blank" present #32780

merged 3 commits into from
Dec 25, 2021

Conversation

balazsorban44
Copy link
Member

When an a tag is used to link to an internal page, but the target="_blank" attribute is present, ESLint should not report it as an error and should not enforce using next/link.

Fixes #28547

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

Sign in to view
ijjk
ijjk reviewed Dec 24, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we add a test for this in this suite https://github.com/vercel/next.js/blob/canary/test/unit/eslint-plugin-next/no-html-link-for-pages.test.ts

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Dec 25, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js feat/allow-blank-target-eslint-internal-url Change
buildDuration 14.5s 14.4s -33ms
buildDurationCached 3.2s 3.3s ⚠️ +94ms
nodeModulesSize 348 MB 348 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js feat/allow-blank-target-eslint-internal-url Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.896 2.955 ⚠️ +0.06
/ avg req/sec 863.41 845.93 ⚠️ -17.48
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.329 1.364 ⚠️ +0.04
/error-in-render avg req/sec 1880.75 1833.43 ⚠️ -47.32
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feat/allow-blank-target-eslint-internal-url Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27 kB 27 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.9 kB 70.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feat/allow-blank-target-eslint-internal-url Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feat/allow-blank-target-eslint-internal-url Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feat/allow-blank-target-eslint-internal-url Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js feat/allow-blank-target-eslint-internal-url Change
index.html gzip 533 B 533 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js feat/allow-blank-target-eslint-internal-url Change
buildDuration 15.9s 16.2s ⚠️ +300ms
buildDurationCached 3.3s 3.2s -35ms
nodeModulesSize 348 MB 348 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js feat/allow-blank-target-eslint-internal-url Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.908 2.905 0
/ avg req/sec 859.68 860.53 +0.85
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.355 1.335 -0.02
/error-in-render avg req/sec 1844.52 1872.54 +28.02
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feat/allow-blank-target-eslint-internal-url Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.1 kB 71.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feat/allow-blank-target-eslint-internal-url Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feat/allow-blank-target-eslint-internal-url Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.75 kB 4.75 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feat/allow-blank-target-eslint-internal-url Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js feat/allow-blank-target-eslint-internal-url Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 494beae

@kodiakhq kodiakhq bot merged commit 4e345f6 into canary Dec 25, 2021
@kodiakhq kodiakhq bot deleted the feat/allow-blank-target-eslint-internal-url branch December 25, 2021 00:55
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ESLint] no-html-link-for-pages false positive on target="_blank"
2 participants
@balazsorban44 @ijjk
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy