Skip to content

chore: decrease stale time before closing issues with no reproduction #32955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2022
Merged

chore: decrease stale time before closing issues with no reproduction #32955

merged 2 commits into from
Jan 3, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Jan 3, 2022 •
edited
Loading

#32214 intended to only allow 30 days of stale time and then close the issue.

After studying the docs:

and the cron job action: https://github.com/vercel/next.js/actions/runs/1647416426

I realized that we currently mark an inactive issue without reproduction as stale after 60 days and wait another 30 days before actually closing it.

With this PR, we mark issues with no reproduction as stale after 30 days and close them the day after.

This should result in a lower count of issues that are unactionable and the author seems to have moved on.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Jan 3, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js chore/decrease-stale-no-reproduction Change
buildDuration 14s 14.2s ⚠️ +135ms
buildDurationCached 3.2s 3.2s -2ms
nodeModulesSize 348 MB 348 MB -7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js chore/decrease-stale-no-reproduction Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.86 2.871 ⚠️ +0.01
/ avg req/sec 874.05 870.64 ⚠️ -3.41
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.289 1.298 ⚠️ +0.01
/error-in-render avg req/sec 1939.54 1926.44 ⚠️ -13.1
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js chore/decrease-stale-no-reproduction Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27 kB 27 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.9 kB 70.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/decrease-stale-no-reproduction Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js chore/decrease-stale-no-reproduction Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.74 kB 4.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js chore/decrease-stale-no-reproduction Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/decrease-stale-no-reproduction Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js chore/decrease-stale-no-reproduction Change
buildDuration 15.5s 15.3s -172ms
buildDurationCached 3.2s 3.2s -6ms
nodeModulesSize 348 MB 348 MB -7 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js chore/decrease-stale-no-reproduction Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.895 2.843 -0.05
/ avg req/sec 863.59 879.26 +15.67
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.306 1.278 -0.03
/error-in-render avg req/sec 1914.94 1956.37 +41.43
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js chore/decrease-stale-no-reproduction Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.1 kB 71.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/decrease-stale-no-reproduction Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js chore/decrease-stale-no-reproduction Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.76 kB 4.76 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js chore/decrease-stale-no-reproduction Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/decrease-stale-no-reproduction Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 79f31de

@kodiakhq kodiakhq bot merged commit 09456cb into canary Jan 3, 2022
@kodiakhq kodiakhq bot deleted the chore/decrease-stale-no-reproduction branch January 3, 2022 03:52
@vercel vercel locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balazsorban44 @ijjk
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy