Actions
Bug #11194
closed
Refactor env-sourced proxy logic for uri/generic
Description
For https://github.com/jruby/jruby/issues/2983 we are modifying uri/generic.rb's find_proxy logic to also check the JVM properties used to configure proxies.
The diff is here: https://gist.github.com/headius/6272d168cf165ddf675f
There are two changes:
- The logic for looking up proxy host and non-proxy addresses from ENV has been pulled out into private utility methods. This change should be zero-sum, and I'd like to commit it to HEAD.
- Additional logic has been added for looking up JVM properties.
I will proceed with the refactor in (1) regardless, but I need community help:
- Any concerns about adding these methods?
- Could we perhaps check RUBY_ENGINE and put the JRuby logic in the canonical uri/generic.rb?
Currently we maintain our own fork of stdlib, and if ruby-core folks don't mind we'd REALLY like to get rid of it. That requires adding a few RUBY_ENGINE checks to MRI's stdlib.
Thoughts?
Updated by headius (Charles Nutter) about 10 years ago
The net/http changes can be ignored; they remove an earlier incorrect mechanism for honoring the JVM properties.
Updated by headius (Charles Nutter) over 4 years ago
This has been addressed in the URI gem by https://github.com/ruby/uri/pull/18.
Updated by jeremyevans0 (Jeremy Evans) over 4 years ago
- Status changed from Open to Closed
Actions
Like0
Like0Like0Like0