Add getUri signature to TypeScript definition.
#1736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in support of #1624.
index.d.ts
Outdated
| @@ -127,6 +127,7 @@ export interface AxiosInstance { | |||
| request: AxiosInterceptorManager<AxiosRequestConfig>; | |||
| response: AxiosInterceptorManager<AxiosResponse>; | |||
| }; | |||
| getUri(config: AxiosRequestConfig): string; | |||
There was a problem hiding this comment.
config should be optional (it falls back to only using the default settings)
|
Thank you @atrauzzi! There's just the small update needed (see my comment) and I'll merge this. |
|
Woops! I should have known that... 😄 Alright, change made! |
emilyemorehouse
approved these changes
Aug 21, 2018
This was referenced Aug 13, 2019
This was referenced Aug 29, 2019
This was referenced Sep 22, 2019
This was referenced Oct 16, 2019
This was referenced Oct 26, 2019
This was referenced Apr 2, 2020
Closed
This was referenced Apr 13, 2020
This was referenced Apr 21, 2020
This was referenced Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in support of #1624. It adds a definition for the
getUrifeature added by @delirius325 to the base axios type.