parse auth headers using pyparsing instead of regexp #182
+579
−1,032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@b-c-ds please take a look too, I can't add you to reviewers. |
b9a3c22 to
987e995
Compare
|
minor update in script/release to read |
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 76.16% 76.26% +0.10%
==========================================
Files 8 12 +4
Lines 2618 2667 +49
==========================================
+ Hits 1994 2034 +40
- Misses 624 633 +9
Continue to review full report at Codecov.
|
|
@temoto I'd never heard of the pyparsing module before... seems like a great alternative to regex. Looks good to me. 👍 |
Fixes CPU burn DoS by cubic complexity of whitespace matching in WWW_AUTH_RELAXED (default) regexp.
987e995 to
bd9ee25
Compare
|
Hello, do you know when you are planning to merge this? |
|
@b-c-ds hey, thanks for reminder, I was waiting for more reviews. This fix is released in 0.19.0. |
This was referenced Mar 6, 2021
1 task
This was referenced Mar 13, 2021
This was referenced Mar 15, 2021
This was referenced Apr 26, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CPU burn DoS by cubic complexity of whitespace matching in
WWW_AUTH_RELAXED (default) regexp.