Skip to content

Caching update information in reports to increase performance #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

andrzejj0
Copy link
Contributor

@andrzejj0 andrzejj0 commented Oct 10, 2022

Noticed some duplication of calls to AbstractVersionDetails::getOldestUpdate and similar: e.g. the same information is retrieved first during the rendering of the "Overview" section to gather aggregate information, then the call is repeated to render update details.

@andrzejj0 andrzejj0 force-pushed the reports-add-caching branch from f48f93c to 1940218 Compare October 10, 2022 06:57
@andrzejj0
Copy link
Contributor Author

@slawekjaranowski please review

@andrzejj0 andrzejj0 force-pushed the reports-add-caching branch from 1940218 to f1c31a8 Compare October 10, 2022 07:31
@andrzejj0 andrzejj0 force-pushed the reports-add-caching branch from f1c31a8 to 0c66cc5 Compare October 10, 2022 08:22
@slawekjaranowski slawekjaranowski added this to the 2.13.0 milestone Oct 12, 2022
@slawekjaranowski slawekjaranowski merged commit f0bfd96 into mojohaus:master Oct 12, 2022
@andrzejj0 andrzejj0 deleted the reports-add-caching branch October 12, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy