Add support for absolute plugin paths #4533
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4533 +/- ##
==========================================
- Coverage 98.89% 98.86% -0.03%
==========================================
Files 208 208
Lines 7332 7334 +2
Branches 2094 2095 +1
==========================================
Hits 7251 7251
- Misses 26 27 +1
- Partials 55 56 +1
Continue to review full report at Codecov.
|
03fadcd to
b08c3a6
Compare
There was a problem hiding this comment.
While the approach looks reasonable, your implementation was referencing a file from the build output, which means subsequent builds would not have worked. Also, you did not add a test (which would have shown that your solution does not work).
I fixed this and extended an existing test to also work on Windows. Also, you should probably use pathToFileUrl instead of just prepending file:// as the latter was failing for me due to wrong path separators.
Please give the branch another go, if CI is green and it works for you I will release this. You should be able to install it and try it out via
npm install ygoe/rollup#patch-1
|
I cannot test this because the npm package fails to install. The lenghty error message says something about the command "husky" was not found. I don't know what that means. |
|
I think as CI seems to be happy, I will merge this anyway. |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Plugins can only be specified as package names or relative paths on the command line. This doesn't meet my requirements. When using rollup packaged in my tool application, I need to specify the absolute installation path of a plugin. No other solution will work for me.
I have verified that this change satisfies this requirement in my local installed copy of the code. I don't have any environment for TypeScript or rollup development, so I can only provide the backport of my patched JavaScript source code. I'm unable to provide anything more than this. It's a trivial change though and should be easy to review.
If necessary, I can try to locate the relevant documentation in this repository and update it, too.