Skip to content

feat: Throw an Error if package.json has duplicate "repository" key #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 11, 2020
Merged

feat: Throw an Error if package.json has duplicate "repository" key #1656

merged 7 commits into from
Oct 11, 2020

Conversation

gr2m
Copy link
Member

@gr2m gr2m commented Oct 11, 2020

addresses bad DX reported in #1655 /cc @kentcdodds @travi

travi
travi approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@travi travi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo, but otherwise looks great 👍🏼

@gr2m
Copy link
Member Author

gr2m commented Oct 11, 2020

where's the typo?

gr2m
gr2m commented Oct 11, 2020
View reviewed changes
@travi
Copy link
Member

travi commented Oct 11, 2020

where's the typo?

looks like you found my comment. surprised that it didnt show up in this thread. must be because i still approved 🤷🏼

kentcdodds
kentcdodds approved these changes Oct 11, 2020
View reviewed changes
Copy link

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gr2m gr2m merged commit b8fb35c into master Oct 11, 2020
@gr2m gr2m deleted the 1655/throw-error-on-duplicate-repository-key-in-package-json branch October 11, 2020 21:59
@semantic-release-bot
Copy link
Collaborator

🎉 This PR is included in version 17.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

pull bot pushed a commit to rikhoffbauer/semantic-release that referenced this pull request Oct 11, 2020
@gr2m @pull
feat: throw an Error if package.json has duplicate "repository" key (s…
5ce7726 
…emantic-release#1656)
travi added a commit that referenced this pull request Oct 12, 2020
@travi
Revert "feat: throw an Error if package.json has duplicate "repositor…
3abcbaf 
…y" key (#1656)"

This reverts commit b8fb35c.

fixes #1657
@travi
Copy link
Member

travi commented Oct 12, 2020

i reverted this change for now in order to give us time to understand #1657

@gr2m gr2m mentioned this pull request Oct 12, 2020
Closed
This was referenced Nov 18, 2020
Open
Open
Open
This was referenced Mar 10, 2021
Open
Closed
Open
Closed
Closed
Merged
Closed
This was referenced Mar 16, 2021
Open
Open
Closed
Closed
Closed
Closed
Open
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travi travi travi approved these changes

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gr2m @travi @semantic-release-bot @kentcdodds
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy