use only alias field properties #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevent checking object prototype properties
Codecov Report
@@ Coverage Diff @@
## main #340 +/- ##
==========================================
- Coverage 95.06% 95.05% -0.01%
==========================================
Files 39 39
Lines 1620 1618 -2
==========================================
- Hits 1540 1538 -2
Misses 80 80
Continue to review full report at Codecov.
|
|
it exports/imports field we using enumerable keys only, so it should be safe |
sokra
requested changes
Apr 4, 2022
lib/AliasFieldPlugin.js
Outdated
Comment on lines
57
to
60
| : Object.prototype.hasOwnProperty.call( | ||
| fieldData, | ||
| innerRequest.replace(/^\.\//, "") | ||
| ) |
There was a problem hiding this comment.
Suggested change
| : Object.prototype.hasOwnProperty.call( | |
| fieldData, | |
| innerRequest.replace(/^\.\//, "") | |
| ) | |
| : innerRequest.startsWith("./") && Object.prototype.hasOwnProperty.call( | |
| fieldData, | |
| innerRequest.slice(2) | |
| ) |
sokra
approved these changes
Apr 12, 2022
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent checking object prototype properties
fixes #118