Merge pull request SpinlockLabs#71 from kevmoo/add_perPage_to_listByRepo

azenla · azenla · commit 5f2c34e6e42e · 2015-12-04T14:56:02.000-08:00
Add per page to list by repo
diff --git a/lib/src/common/issues_service.dart b/lib/src/common/issues_service.dart
@@ -11,26 +11,39 @@ class IssuesService extends Service {
   /// including owned repositories, member repositories, and organization repositories
   ///
   /// API docs: https://developer.github.com/v3/issues/#list-issues
-  Stream<Issue> listAll() {
-    return new PaginationHelper(_github)
-        .objects("GET", "/issues", Issue.fromJSON);
+  Stream<Issue> listAll(
+      {String state,
+      String direction,
+      String sort,
+      DateTime since,
+      int perPage}) {
+    return _listIssues("/issues", state, direction, sort, since, perPage);
   }
 
   /// List all issues across owned and member repositories for the authenticated
   /// user.
   ///
   /// API docs: https://developer.github.com/v3/issues/#list-issues
-  Stream<Issue> listByUser() {
-    return new PaginationHelper(_github)
-        .objects("GET", "/user/issues", Issue.fromJSON);
+  Stream<Issue> listByUser(
+      {String state,
+      String direction,
+      String sort,
+      DateTime since,
+      int perPage}) {
+    return _listIssues("/user/issues", state, direction, sort, since, perPage);
   }
 
   /// List all issues for a given organization for the authenticated user.
   ///
   /// API docs: https://developer.github.com/v3/issues/#list-issues
-  Stream<Issue> listByOrg(String org) {
-    return new PaginationHelper(_github)
-        .objects("GET", "/orgs/${org}/issues", Issue.fromJSON);
+  Stream<Issue> listByOrg(String org,
+      {String state,
+      String direction,
+      String sort,
+      DateTime since,
+      int perPage}) {
+    return _listIssues(
+        "/orgs/${org}/issues", state, direction, sort, since, perPage);
   }
 
   /// Lists the issues for the specified repository.
@@ -39,8 +52,23 @@ class IssuesService extends Service {
   ///
   /// API docs:https://developer.github.com/v3/issues/#list-issues-for-a-repository
   Stream<Issue> listByRepo(RepositorySlug slug,
-      {String state, String direction, String sort, DateTime since}) {
+      {String state,
+      String direction,
+      String sort,
+      DateTime since,
+      int perPage}) {
+    return _listIssues("/repos/${slug.fullName}/issues", state, direction, sort,
+        since, perPage);
+  }
+
+  Stream<Issue> _listIssues(String pathSegment, String state, String direction,
+      String sort, DateTime since, int perPage) {
     var params = <String, String>{};
+
+    if (perPage != null) {
+      params['per_page'] = perPage.toString();
+    }
+
     if (state != null) {
       // should be `open`, `closed` or `all`
       params['state'] = state;
@@ -62,9 +90,8 @@ class IssuesService extends Service {
       params['since'] = since.toUtc().toIso8601String();
     }
 
-    return new PaginationHelper(_github).objects(
-        "GET", "/repos/${slug.fullName}/issues", Issue.fromJSON,
-        params: params);
+    return new PaginationHelper(_github)
+        .objects("GET", pathSegment, Issue.fromJSON, params: params);
   }
 
   /// Edit an issue.
diff --git a/test/git_integration_test.dart b/test/git_integration_test.dart
@@ -96,7 +96,7 @@ main() {
   test('create and get a new reference (branch)', () async {
     var branchName = _randomGitName();
 
-    var createdRef = await github.git
+    await github.git
         .createReference(slug, 'refs/heads/$branchName', createdCommitSha);
 
     var fetchedRef = await github.git.getReference(slug, 'heads/$branchName');
