Merge pull request SpinlockLabs#82 from kevmoo/issue_foo

Pacane · web-flow · commit 8eb290efd13a · 2016-09-30T15:31:16.000-04:00
Throw an error if an issue is not found
diff --git a/lib/src/common/issues_service.dart b/lib/src/common/issues_service.dart
@@ -241,7 +241,7 @@ class IssuesService extends Service {
   /// API docs: https://developer.github.com/v3/issues/labels/#get-a-single-label
   Future<IssueLabel> getLabel(RepositorySlug slug, String name) {
     return _github.getJSON("/repos/${slug.fullName}/labels/${name}",
-        convert: IssueLabel.fromJSON);
+        convert: IssueLabel.fromJSON, statusCode: StatusCodes.OK);
   }
 
   /// Creates a new label on the specified repository.
diff --git a/lib/src/common/model/issues.dart b/lib/src/common/model/issues.dart
@@ -181,6 +181,9 @@ class IssueLabel {
   static IssueLabel fromJSON(input) {
     if (input == null) return null;
 
+    assert(input['name'] != null);
+    assert(input['color'] != null);
+
     return new IssueLabel()
       ..name = input['name']
       ..color = input['color'];

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,7 @@ class IssuesService extends Service {`
`241`	`241`	`/// API docs: https://developer.github.com/v3/issues/labels/#get-a-single-label`
`242`	`242`	`Future<IssueLabel> getLabel(RepositorySlug slug, String name) {`
`243`	`243`	`return _github.getJSON("/repos/${slug.fullName}/labels/${name}",`
`244`		`- convert: IssueLabel.fromJSON);`
	`244`	`+ convert: IssueLabel.fromJSON, statusCode: StatusCodes.OK);`
`245`	`245`	`}`
`246`	`246`
`247`	`247`	`/// Creates a new label on the specified repository.`