raise ldap.PROTOCOL_ERROR if compare operation returned a wrong result

stroeder · stroeder · commit bad14b5a9ba8 · 2017-11-20T10:53:51.000Z
diff --git a/Lib/ldap/ldapobject/__init__.py b/Lib/ldap/ldapobject/__init__.py
@@ -425,7 +425,7 @@ def compare_ext(self, dn, attr, value, serverctrls=None, clientctrls=None):
     def compare_ext_s(self, dn, attr, value, serverctrls=None, clientctrls=None):
         msgid = self.compare_ext(dn, attr, value, serverctrls, clientctrls)
         try:
-            resp_type, resp_data, resp_msgid, resp_ctrls = self.result3(
+            ldap_res = self.result3(
                 msgid,
                 all=1,
                 timeout=self.timeout
@@ -434,7 +434,9 @@ def compare_ext_s(self, dn, attr, value, serverctrls=None, clientctrls=None):
             return True
         except ldap.COMPARE_FALSE:
             return False
-        return None
+        raise ldap.PROTOCOL_ERROR(
+            'Compare operation returned wrong result: %r' % (ldap_res)
+        )
 
     def compare(self, dn, attr, value):
         return self.compare_ext(dn, attr, value, None, None)
