Skip to content

Commit 6443ff7

Browse files
committed
fix ut.新添加的图层在themelayer列表中追加一条。之前错误的原因是本地只跑了一个it。误以为先添加的图层是childnode[0].实际应该是childnode[childList.length-1]
1 parent 2489db8 commit 6443ff7

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

test/mapboxgl/overlay/GraphThemeLayerSpec.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ describe('mapboxgl_GraphThemeLayer', () => {
308308
graphThemeLayer.setVisibility(false);
309309
expect(graphThemeLayer.visibility).toBeFalsy();
310310
});
311-
311+
312312
it('moveTo', () => {
313313
const graphThemeLayer = new Graph("GraphThemeLayer", "Bar", {
314314
map: map,
@@ -322,6 +322,7 @@ describe('mapboxgl_GraphThemeLayer', () => {
322322
charts: [1, 2, 3],
323323
cache: { 'name': 'ONETWO' }
324324
});
325+
var length1 = graphThemeLayer.div.parentNode.getElementsByClassName("themeLayer").length;
325326
//ThemeLayer 75行已经添加过一次了
326327
// map.addLayer(graphThemeLayer);
327328
const graphThemeLayer2 = new Graph("GraphThemeLayer2", "Bar", {
@@ -338,9 +339,9 @@ describe('mapboxgl_GraphThemeLayer', () => {
338339
});
339340
//ThemeLayer 75行已经添加过一次了
340341
// map.addLayer(graphThemeLayer2);
341-
//移动前,第一个layer是第一个
342-
expect(graphThemeLayer.div.parentNode.getElementsByClassName("themeLayer")[0].id).toEqual(graphThemeLayer.id);
342+
//移动前,第一个layer是倒数第二个
343+
expect(graphThemeLayer.div.parentNode.getElementsByClassName("themeLayer")[length1-1].id).toEqual(graphThemeLayer.id);
343344
graphThemeLayer2.moveTo(graphThemeLayer.id);
344-
expect(graphThemeLayer.div.parentNode.getElementsByClassName("themeLayer")[0].id).toEqual(graphThemeLayer2.id);
345+
expect(graphThemeLayer.div.parentNode.getElementsByClassName("themeLayer")[length1-1].id).toEqual(graphThemeLayer2.id);
345346
});
346347
});

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy