Skip to content

Add PSR3 Logger community modules #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2019
Merged

Add PSR3 Logger community modules #173

merged 2 commits into from
Aug 10, 2019

Conversation

zmajciki
Copy link
Contributor

@zmajciki zmajciki commented Aug 7, 2019

This module provides actions to test code which depends on PSR3 compatible logger.

zmajciki added 2 commits August 7, 2019 13:15
@zmajciki
Add PSR3 Logger community modules
a6687b7 
This module provides actions to test code which depends on PSR3 compatible logger.
@zmajciki
Update PSR3 logger description
99f3470
@Naktibalda
Copy link
Member

Naktibalda commented Aug 10, 2019 •
edited
Loading

I looked at your module and noticed methods names haveEmergency, haveCritical.
There is absolutely no requirement to use have prefix for all methods that do something.
Names like logEmergency or, even better, logEmergencyMessage would look much more natural.

@Naktibalda Naktibalda merged commit b79f62e into Codeception:master Aug 10, 2019
@zmajciki
Copy link
Contributor Author

Thank you for suggestion, I agree. We can rename methods with the next major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmajciki @Naktibalda
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy