From 9043c552961841057ef9d0f520417453fe38ed37 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fernando=20K=C3=BCpper=20Cardoso?= Date: Fri, 30 Jul 2021 16:31:24 +0200 Subject: [PATCH 1/3] fix: uploaded files should have `test` flag set to `true` --- src/Codeception/Lib/Connector/Laravel.php | 32 +++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/src/Codeception/Lib/Connector/Laravel.php b/src/Codeception/Lib/Connector/Laravel.php index 831f9e0..7adce35 100644 --- a/src/Codeception/Lib/Connector/Laravel.php +++ b/src/Codeception/Lib/Connector/Laravel.php @@ -463,4 +463,36 @@ public function clearApplicationHandlers(): void { $this->applicationHandlers = []; } + + /** + * Make sure files are \Illuminate\Http\UploadedFile instances with the private $test property set to true. + * Fixes issue https://github.com/Codeception/Codeception/pull/3417. + * + * @param array $files + * @return array + */ + protected function filterFiles(array $files) + { + $files = parent::filterFiles($files); + return $this->convertToTestFiles($files); + } + + /** + * @param array $files + * @return array + */ + private function convertToTestFiles(array $files): array + { + $filtered = []; + + foreach ($files as $key => $value) { + if (is_array($value)) { + $filtered[$key] = $this->convertToTestFiles($value); + } else { + $filtered[$key] = UploadedFile::createFromBase($value, true); + } + } + + return $filtered; + } } From 4984904e1ac16d0283cef5180ce27b1ded7a044d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fernando=20K=C3=BCpper=20Cardoso?= Date: Fri, 30 Jul 2021 22:10:29 +0200 Subject: [PATCH 2/3] Update src/Codeception/Lib/Connector/Laravel.php Co-authored-by: Tavo Nieves J <64917965+TavoNiievez@users.noreply.github.com> --- src/Codeception/Lib/Connector/Laravel.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Codeception/Lib/Connector/Laravel.php b/src/Codeception/Lib/Connector/Laravel.php index 7adce35..7707eab 100644 --- a/src/Codeception/Lib/Connector/Laravel.php +++ b/src/Codeception/Lib/Connector/Laravel.php @@ -471,7 +471,7 @@ public function clearApplicationHandlers(): void * @param array $files * @return array */ - protected function filterFiles(array $files) + protected function filterFiles(array $files): array { $files = parent::filterFiles($files); return $this->convertToTestFiles($files); From 93173aca1b2d0ddc6addb61b84debc4dbff420d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fernando=20K=C3=BCpper=20Cardoso?= Date: Fri, 30 Jul 2021 22:11:55 +0200 Subject: [PATCH 3/3] chore: remove unnecessary docblock --- src/Codeception/Lib/Connector/Laravel.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/Codeception/Lib/Connector/Laravel.php b/src/Codeception/Lib/Connector/Laravel.php index 7707eab..5351bb6 100644 --- a/src/Codeception/Lib/Connector/Laravel.php +++ b/src/Codeception/Lib/Connector/Laravel.php @@ -477,10 +477,6 @@ protected function filterFiles(array $files): array return $this->convertToTestFiles($files); } - /** - * @param array $files - * @return array - */ private function convertToTestFiles(array $files): array { $filtered = []; pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy