Fix some types (#21)

TavoNiievez · web-flow · commit fda6d97253d0 · 2021-12-21T10:16:28.000-05:00
diff --git a/src/Codeception/Lib/Connector/Guzzle.php b/src/Codeception/Lib/Connector/Guzzle.php
@@ -156,7 +156,7 @@ protected function createResponse(Psr7Response $psr7Response): BrowserKitRespons
         return new BrowserKitResponse($body, $status, $headers);
     }
 
-    protected function getAbsoluteUri($uri)
+    protected function getAbsoluteUri(string $uri): string
     {
         $baseUri = $this->client->getConfig('base_uri');
         if (strpos($uri, '://') === false && strpos($uri, '//') !== 0) {
diff --git a/tests/unit/Codeception/Module/TestsForWeb.php b/tests/unit/Codeception/Module/TestsForWeb.php
@@ -1212,7 +1212,7 @@ public function testClickLinkWithInnerSpan()
     public function testSelectTwoSubmitsByText()
     {
         $this->module->amOnPage('/form/select_two_submits');
-        $this->module->selectOption('What kind of sandwich would you like?', 2);
+        $this->module->selectOption('What kind of sandwich would you like?', '2');
         $this->module->click('Save');
 
         $form = data::get('form');

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ protected function createResponse(Psr7Response $psr7Response): BrowserKitRespons`
`156`	`156`	`return new BrowserKitResponse($body, $status, $headers);`
`157`	`157`	`}`
`158`	`158`
`159`		`- protected function getAbsoluteUri($uri)`
	`159`	`+ protected function getAbsoluteUri(string $uri): string`
`160`	`160`	`{`
`161`	`161`	`$baseUri = $this->client->getConfig('base_uri');`
`162`	`162`	`if (strpos($uri, '://') === false && strpos($uri, '//') !== 0) {`
Original file line number	Diff line number	Diff line change
`@@ -1212,7 +1212,7 @@ public function testClickLinkWithInnerSpan()`
`1212`	`1212`	`public function testSelectTwoSubmitsByText()`
`1213`	`1213`	`{`
`1214`	`1214`	`$this->module->amOnPage('/form/select_two_submits');`
`1215`		`- $this->module->selectOption('What kind of sandwich would you like?', 2);`
	`1215`	`+ $this->module->selectOption('What kind of sandwich would you like?', '2');`
`1216`	`1216`	`$this->module->click('Save');`
`1217`	`1217`
`1218`	`1218`	`$form = data::get('form');`