Skip to content

Commit 6b2898d

Browse files
authored
test: unskip tests (microsoft#840)
1 parent 12ba09d commit 6b2898d

File tree

3 files changed

+3
-14
lines changed

3 files changed

+3
-14
lines changed

tests/async/test_browsercontext_storage_state.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,8 @@
1515
import asyncio
1616
import json
1717

18-
import pytest
19-
2018

2119
async def test_should_capture_local_storage(context, is_webkit, is_win):
22-
if is_webkit and is_win:
23-
pytest.skip()
2420
page1 = await context.new_page()
2521
await page1.route(
2622
"**/*", lambda route: asyncio.create_task(route.fulfill(body="<html></html>"))
@@ -44,8 +40,6 @@ async def test_should_capture_local_storage(context, is_webkit, is_win):
4440

4541

4642
async def test_should_set_local_storage(browser, is_webkit, is_win):
47-
if is_webkit and is_win:
48-
pytest.skip()
4943
context = await browser.new_context(
5044
storage_state={
5145
"origins": [

tests/async/test_network.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,8 @@ def handle(request):
198198
assert cast(Response, response).request.headers == server_headers
199199

200200

201+
# TODO: update once fixed https://github.com/microsoft/playwright/issues/6690
202+
@pytest.mark.xfail
201203
async def test_request_headers_should_get_the_same_headers_as_the_server_cors(
202204
page: Page, server, is_webkit, is_win
203205
):
@@ -562,11 +564,10 @@ async def test_network_events_should_support_redirects(page, server):
562564

563565

564566
async def test_request_is_navigation_request_should_work(page, server):
565-
pytest.skip(msg="test")
566567
requests = {}
567568

568569
def handle_request(request):
569-
requests[request.url().split("/").pop()] = request
570+
requests[request.url.split("/").pop()] = request
570571

571572
page.on("request", handle_request)
572573
server.set_redirect("/rrredirect", "/frames/one-frame.html")

tests/sync/test_browsercontext_storage_state.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,8 @@
1414

1515
import json
1616

17-
import pytest
18-
1917

2018
def test_should_capture_local_storage(context, is_webkit, is_win):
21-
if is_webkit and is_win:
22-
pytest.skip()
2319
page1 = context.new_page()
2420
page1.route("**/*", lambda route: route.fulfill(body="<html></html>"))
2521
page1.goto("https://www.example.com")
@@ -41,8 +37,6 @@ def test_should_capture_local_storage(context, is_webkit, is_win):
4137

4238

4339
def test_should_set_local_storage(browser, is_webkit, is_win):
44-
if is_webkit and is_win:
45-
pytest.skip()
4640
context = browser.new_context(
4741
storage_state={
4842
"origins": [

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy