Move all the modules used in 1/2 of all pages into the common chunks. (vercel#1659)

arunoda · rauchg · commit 060cac3e3f43 · 2017-04-07T11:39:00.000-07:00
diff --git a/server/build/webpack.js b/server/build/webpack.js
@@ -36,7 +36,7 @@ export default async function createCompiler (dir, { dev = false, quiet = false,
   const mainJS = dev
     ? require.resolve('../../client/next-dev') : require.resolve('../../client/next')
 
-  let minChunks
+  let totalPages
 
   const entry = async () => {
     const entries = {
@@ -68,8 +68,7 @@ export default async function createCompiler (dir, { dev = false, quiet = false,
       }
     }
 
-    // calculate minChunks of CommonsChunkPlugin for later use
-    minChunks = Math.max(2, pages.filter((p) => p !== documentPage).length)
+    totalPages = pages.filter((p) => p !== documentPage).length
 
     return entries
   }
@@ -101,9 +100,8 @@ export default async function createCompiler (dir, { dev = false, quiet = false,
           return module.context && module.context.indexOf('node_modules') >= 0
         }
 
-        // NOTE: it depends on the fact that the entry funtion is always called
-        // before applying CommonsChunkPlugin
-        return count >= minChunks
+        // Move modules used in at-least 1/2 of the total pages into commons.
+        return count >= totalPages * 0.5
       }
     }),
     // This chunk contains all the webpack related code. So, all the changes

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ export default async function createCompiler (dir, { dev = false, quiet = false,`
`36`	`36`	`const mainJS = dev`
`37`	`37`	`? require.resolve('../../client/next-dev') : require.resolve('../../client/next')`
`38`	`38`
`39`		`- let minChunks`
	`39`	`+ let totalPages`
`40`	`40`
`41`	`41`	`const entry = async () => {`
`42`	`42`	`const entries = {`
`@@ -68,8 +68,7 @@ export default async function createCompiler (dir, { dev = false, quiet = false,`
`68`	`68`	`}`
`69`	`69`	`}`
`70`	`70`
`71`		`- // calculate minChunks of CommonsChunkPlugin for later use`
`72`		`- minChunks = Math.max(2, pages.filter((p) => p !== documentPage).length)`
	`71`	`+ totalPages = pages.filter((p) => p !== documentPage).length`
`73`	`72`
`74`	`73`	`return entries`
`75`	`74`	`}`
`@@ -101,9 +100,8 @@ export default async function createCompiler (dir, { dev = false, quiet = false,`
`101`	`100`	`return module.context && module.context.indexOf('node_modules') >= 0`
`102`	`101`	`}`
`103`	`102`
`104`		`- // NOTE: it depends on the fact that the entry funtion is always called`
`105`		`- // before applying CommonsChunkPlugin`
`106`		`- return count >= minChunks`
	`103`	`+ // Move modules used in at-least 1/2 of the total pages into commons.`
	`104`	`+ return count >= totalPages * 0.5`
`107`	`105`	`}`
`108`	`106`	`}),`
`109`	`107`	`// This chunk contains all the webpack related code. So, all the changes`