[with-firebase] Ensure server credentials aren't bundled with client code (vercel#1875)

Ehesp · timneutkens · commit 605161df8aba · 2017-05-08T21:53:48.000+02:00
* [with-firebase] Ensure server credentials aren't bundled with client code

* [with-firebase] Fix travis build failure
diff --git a/examples/with-firebase/credentials/client.js b/examples/with-firebase/credentials/client.js
@@ -0,0 +1,3 @@
+module.exports = {
+    // TODO firebase client config
+}
diff --git a/examples/with-firebase/credentials/server.js b/examples/with-firebase/credentials/server.js
@@ -0,0 +1,3 @@
+module.exports = {
+    // TODO firebase server config
+}
diff --git a/examples/with-firebase/firebaseCredentials.js b/examples/with-firebase/firebaseCredentials.js
diff --git a/examples/with-firebase/pages/index.js b/examples/with-firebase/pages/index.js
@@ -1,7 +1,7 @@
 import React, { Component } from 'react'
 import firebase from 'firebase'
 import 'isomorphic-fetch'
-import { clientCredentials } from '../firebaseCredentials'
+import clientCredentials from '../credentials/client'
 
 export default class Index extends Component {
   static async getInitialProps ({req, query}) {
diff --git a/examples/with-firebase/server.js b/examples/with-firebase/server.js
@@ -10,7 +10,7 @@ const app = next({ dev })
 const handle = app.getRequestHandler()
 
 const firebase = admin.initializeApp({
-  credential: admin.credential.cert(require('./firebaseCredentials').serverCredentials),
+  credential: admin.credential.cert(require('./credentials/server')),
   databaseURL: '' // TODO database URL goes here
 }, 'server')
 
