Do not add double slash to submission ZIP URL's when shadowing

nickygerritsen · nickygerritsen · commit cef4339fe4ba · 2025-04-30T18:11:32.000Z
diff --git a/webapp/src/Service/ExternalContestSourceService.php b/webapp/src/Service/ExternalContestSourceService.php
@@ -1435,6 +1435,10 @@ protected function importSubmission(Event $event, EventData $data): void
                 $zipUrl = $data->files[0]->href;
                 if (preg_match('/^https?:\/\//', $zipUrl) === 0) {
                     // Relative URL, prepend the base URL.
+                    // If the base URL ends with a slash and the zip URL starts with one, remove the slash.
+                    if (str_ends_with($this->basePath, '/') && str_starts_with($zipUrl, '/')) {
+                        $zipUrl = substr($zipUrl, 1);
+                    }
                     $zipUrl = ($this->basePath ?? '') . $zipUrl;
                 }
 
