Merge pull request TheAlgorithms#766 from abhijay94/Development

yanglbme · web-flow · commit ceae5ee44a24 · 2019-05-23T14:47:32.000+08:00
Cast the second operand of Math.pow to double - SonarQube analysis
diff --git a/src/main/java/com/crypto/codec/Base64.java b/src/main/java/com/crypto/codec/Base64.java
@@ -184,7 +184,7 @@ private static byte[] decodeBlock(byte[] block) {
 
         decodedBlock[0] = (byte) (decodeAlphabet[block[0]] << 2 | decodeAlphabet[block[1]] >>> 4);
         decodedBlock[1] = (byte) (decodeAlphabet[block[1]] << 4 | decodeAlphabet[block[2]] >>> 2);
-        decodedBlock[2] = (byte) (decodeAlphabet[block[2]] << 6 | decodeAlphabet[block[3]]);
+        decodedBlock[2] = (byte) (decodeAlphabet[block[2]] << 6 | decodeAlphabet[block[3]] & 0xff);
 
         return decodedBlock;
     }
diff --git a/src/main/java/com/generation/SimplexNoise.java b/src/main/java/com/generation/SimplexNoise.java
@@ -36,7 +36,7 @@ public SimplexNoise(int largestFeature, double persistence, long seed) {
 
             this.octaves[index] = new SimplexNoiseOctave(random.nextInt());
             this.frequencys[index] = Math.pow(2, index);
-            this.amplitudes[index] = Math.pow(persistence, octaveCount - index);
+            this.amplitudes[index] = Math.pow(persistence, (double) octaveCount - index);
         }
     }
 
@@ -103,7 +103,7 @@ public double getNoise(int x, int y, int z) {
         for (int index = 0; index < this.octaves.length; index++) {
 
             double frequency = Math.pow(2, index);
-            double amplitude = Math.pow(this.persistance, this.octaves.length - index);
+            double amplitude = Math.pow(this.persistance, (double) this.octaves.length - index);
 
             result += this.octaves[index].noise(x / frequency, y / frequency, z / frequency) * amplitude;
         }

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ private static byte[] decodeBlock(byte[] block) {`
`184`	`184`
`185`	`185`	`decodedBlock[0] = (byte) (decodeAlphabet[block[0]] << 2 \| decodeAlphabet[block[1]] >>> 4);`
`186`	`186`	`decodedBlock[1] = (byte) (decodeAlphabet[block[1]] << 4 \| decodeAlphabet[block[2]] >>> 2);`
`187`		`- decodedBlock[2] = (byte) (decodeAlphabet[block[2]] << 6 \| decodeAlphabet[block[3]]);`
	`187`	`+ decodedBlock[2] = (byte) (decodeAlphabet[block[2]] << 6 \| decodeAlphabet[block[3]] & 0xff);`
`188`	`188`
`189`	`189`	`return decodedBlock;`
`190`	`190`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public SimplexNoise(int largestFeature, double persistence, long seed) {`
`36`	`36`
`37`	`37`	`this.octaves[index] = new SimplexNoiseOctave(random.nextInt());`
`38`	`38`	`this.frequencys[index] = Math.pow(2, index);`
`39`		`- this.amplitudes[index] = Math.pow(persistence, octaveCount - index);`
	`39`	`+ this.amplitudes[index] = Math.pow(persistence, (double) octaveCount - index);`
`40`	`40`	`}`
`41`	`41`	`}`
`42`	`42`
`@@ -103,7 +103,7 @@ public double getNoise(int x, int y, int z) {`
`103`	`103`	`for (int index = 0; index < this.octaves.length; index++) {`
`104`	`104`
`105`	`105`	`double frequency = Math.pow(2, index);`
`106`		`- double amplitude = Math.pow(this.persistance, this.octaves.length - index);`
	`106`	`+ double amplitude = Math.pow(this.persistance, (double) this.octaves.length - index);`
`107`	`107`
`108`	`108`	`result += this.octaves[index].noise(x / frequency, y / frequency, z / frequency) * amplitude;`
`109`	`109`	`}`