Apply transform on instance instead of applying it when drawing the glyph

BKSalman · BKSalman · commit 4688432acbde · 2025-07-05T17:32:20.000+03:00
diff --git a/node-graph/gcore/src/text/to_path.rs b/node-graph/gcore/src/text/to_path.rs
@@ -21,23 +21,17 @@ thread_local! {
 struct PathBuilder {
 	current_subpath: Subpath<PointId>,
 	glyph_subpaths: Vec<Subpath<PointId>>,
-	other_subpaths: Vec<VectorData>,
-	origin: DVec2,
+	other_subpaths: Vec<crate::instances::Instance<VectorData>>,
 	scale: f64,
 	id: PointId,
 }
 
 impl PathBuilder {
 	fn point(&self, x: f32, y: f32) -> DVec2 {
-		// Y-axis inversion converts from font coordinate system (Y-up) to graphics coordinate system (Y-down)
-		DVec2::new(self.origin.x + x as f64, self.origin.y - y as f64) * self.scale
+		DVec2::new(x as f64, -y as f64) * self.scale
 	}
 
-	fn set_origin(&mut self, x: f64, y: f64) {
-		self.origin = DVec2::new(x, y);
-	}
-
-	fn draw_glyph(&mut self, glyph: &OutlineGlyph<'_>, size: f32, normalized_coords: &[NormalizedCoord], style_skew: Option<DAffine2>, skew: DAffine2) {
+	fn draw_glyph(&mut self, glyph: &OutlineGlyph<'_>, size: f32, normalized_coords: &[NormalizedCoord], glyph_offset: DVec2, style_skew: Option<DAffine2>, skew: DAffine2) {
 		let location_ref = LocationRef::new(normalized_coords);
 		let settings = DrawSettings::unhinted(Size::new(size), location_ref);
 		glyph.draw(settings, self).unwrap();
@@ -53,7 +47,11 @@ impl PathBuilder {
 		}
 
 		if !self.glyph_subpaths.is_empty() {
-			self.other_subpaths.push(VectorData::from_subpaths(core::mem::take(&mut self.glyph_subpaths), false));
+			self.other_subpaths.push(crate::instances::Instance {
+				instance: VectorData::from_subpaths(core::mem::take(&mut self.glyph_subpaths), false),
+				transform: DAffine2::from_translation(glyph_offset),
+				..Default::default()
+			})
 		}
 	}
 }
@@ -145,14 +143,12 @@ fn render_glyph_run(glyph_run: &GlyphRun<'_, ()>, path_builder: &mut PathBuilder
 	let outlines = font_ref.outline_glyphs();
 
 	for glyph in glyph_run.glyphs() {
-		let glyph_x = run_x + glyph.x;
-		let glyph_y = run_y - glyph.y;
+		let glyph_offset = DVec2::new((run_x + glyph.x) as f64, (run_y - glyph.y) as f64);
 		run_x += glyph.advance;
 
 		let glyph_id = GlyphId::from(glyph.id);
 		if let Some(glyph_outline) = outlines.get(glyph_id) {
-			path_builder.set_origin(glyph_x as f64, glyph_y as f64);
-			path_builder.draw_glyph(&glyph_outline, font_size, &normalized_coords, style_skew, skew);
+			path_builder.draw_glyph(&glyph_outline, font_size, &normalized_coords, glyph_offset, style_skew, skew);
 		}
 	}
 }
@@ -187,14 +183,13 @@ fn layout_text(str: &str, font_data: Option<Blob<u8>>, typesetting: TypesettingC
 	Some(layout)
 }
 
-pub fn to_path(str: &str, font_data: Option<Blob<u8>>, typesetting: TypesettingConfig) -> Vec<VectorData> {
+pub fn to_path(str: &str, font_data: Option<Blob<u8>>, typesetting: TypesettingConfig) -> Vec<crate::instances::Instance<VectorData>> {
 	let Some(layout) = layout_text(str, font_data, typesetting) else { return Vec::new() };
 
 	let mut path_builder = PathBuilder {
 		current_subpath: Subpath::new(Vec::new(), false),
 		glyph_subpaths: Vec::new(),
 		other_subpaths: Vec::new(),
-		origin: DVec2::ZERO,
 		scale: layout.scale() as f64,
 		id: PointId::ZERO,
 	};
diff --git a/node-graph/gstd/src/text.rs b/node-graph/gstd/src/text.rs
@@ -1,5 +1,4 @@
 use crate::vector::{VectorData, VectorDataTable};
-use glam::DAffine2;
 use graph_craft::wasm_application_io::WasmEditorApi;
 use graphene_core::Ctx;
 pub use graphene_core::text::*;
@@ -49,13 +48,7 @@ fn text<'i: 'n>(
 	};
 
 	for glyph in glyph_vectors {
-		let instance = graphene_core::instances::Instance {
-			instance: glyph,
-			transform: DAffine2::IDENTITY,
-			..Default::default()
-		};
-
-		glyph_table.push(instance);
+		glyph_table.push(glyph);
 	}
 
 	glyph_table
