inherit child reference from old node when patching static nodes (fix vuejs#4288)

yyx990803 · yyx990803 · commit 1a7b910feb8c · 2016-11-23T09:42:52.000-05:00
diff --git a/src/core/vdom/patch.js b/src/core/vdom/patch.js
@@ -342,6 +342,7 @@ export function createPatchFunction (backend) {
         vnode.key === oldVnode.key &&
         (vnode.isCloned || vnode.isOnce)) {
       vnode.elm = oldVnode.elm
+      vnode.child = oldVnode.child
       return
     }
     let i
diff --git a/test/unit/features/directives/once.spec.js b/test/unit/features/directives/once.spec.js
@@ -313,6 +313,28 @@ describe('Directive v-once', () => {
     expect(vm.$el.textContent).toBe('aabbcc')
     expect(`v-once can only be used inside v-for that is keyed.`).toHaveBeenWarned()
   })
+
+  // #4288
+  it('should inherit child reference for v-once', done => {
+    const vm = new Vue({
+      template: `<div>{{a}}<test v-if="ok" v-once></test></div>`,
+      data: {
+        a: 0,
+        ok: true
+      },
+      components: {
+        test: {
+          template: '<div>foo</div>'
+        }
+      }
+    }).$mount()
+    vm.a++ // first update to force a patch
+    waitForUpdate(() => {
+      expect(vm.$el.textContent).toBe('1foo')
+    }).then(() => {
+      vm.ok = false // teardown component with v-once
+    }).then(done) // should not throw
+  })
 })
 
 function expectTextContent (vm, text) {

Original file line number	Diff line number	Diff line change
`@@ -342,6 +342,7 @@ export function createPatchFunction (backend) {`
`342`	`342`	`vnode.key === oldVnode.key &&`
`343`	`343`	`(vnode.isCloned \|\| vnode.isOnce)) {`
`344`	`344`	`vnode.elm = oldVnode.elm`
	`345`	`+ vnode.child = oldVnode.child`
`345`	`346`	`return`
`346`	`347`	`}`
`347`	`348`	`let i`