feat: set api_domain on base domain env

runawaycoast · runawaycoast · commit c4208c010462 · 2022-08-23T15:03:23.000-04:00
diff --git a/nasdaqdatalink/api_config.py b/nasdaqdatalink/api_config.py
@@ -103,11 +103,11 @@ def read_key_from_environment_variable():
 
 
 def read_api_base_from_environment_variable():
-    api_base = os.environ.get(NASDAQ_DATA_LINK_BASE_DOMAIN)
-    if not api_base:
+    base_domain = os.environ.get(NASDAQ_DATA_LINK_BASE_DOMAIN)
+    if not base_domain:
         raise_empty_environment_variable(NASDAQ_DATA_LINK_BASE_DOMAIN)
 
-    ApiConfig.api_base = api_base
+    ApiConfig.api_base = '{}{}/api/v3'.format(ApiConfig.api_protocol, base_domain)
 
 
 def read_key(filename=None):
diff --git a/test/test_api_config.py b/test/test_api_config.py
@@ -138,11 +138,12 @@ def test_read_key_from_file_with_multi_newline(self):
         given = "keyfordefaultfile\n\nanotherkey\n"
         self._read_key_from_file_helper(given, TEST_DEFAULT_FILE_CONTENTS)
 
+
     def test_read_config_when_environment_variable_set(self):
-        os.environ['NASDAQ_DATA_LINK_BASE_DOMAIN'] = 'api-basein-env'
+        os.environ['NASDAQ_DATA_LINK_BASE_DOMAIN'] = 'testdatalinkdomain.com'
         ApiConfig.api_base = None
         read_config()
-        self.assertEqual(ApiConfig.api_base, 'api-basein-env')
+        self.assertEqual(ApiConfig.api_base, '{}testdatalinkdomain.com/api/v3'.format(ApiConfig.api_protocol))
 
 
     def test_read_config_when_environment_variable_not_set(self):
@@ -153,5 +154,7 @@ def test_read_config_when_environment_variable_not_set(self):
 
     def test_read_config_when_env_key_empty(self):
         os.environ['NASDAQ_DATA_LINK_BASE_DOMAIN'] = ''
+        ApiConfig.api_base = 'prevapibase'
         with self.assertRaises(ValueError):
             read_config()
+        self.assertEqual(ApiConfig.api_base, 'prevapibase')
