Make resolve_client private.

fkdosilovic · fkdosilovic · commit ca915ff88866 · 2024-11-25T21:41:23.000+01:00
diff --git a/src/judge0/api.py b/src/judge0/api.py
@@ -20,7 +20,7 @@ def get_client(flavor: Flavor = Flavor.CE) -> Client:
         )
 
 
-def resolve_client(
+def _resolve_client(
     client: Optional[Union[Client, Flavor]] = None,
     submissions: Optional[Union[Submission, Submissions]] = None,
 ) -> Client:
@@ -60,7 +60,7 @@ def create_submissions(
     client: Optional[Client] = None,
     submissions: Optional[Union[Submission, Submissions]] = None,
 ) -> Union[Submission, Submissions]:
-    client = resolve_client(client=client, submissions=submissions)
+    client = _resolve_client(client=client, submissions=submissions)
 
     if isinstance(submissions, Submission):
         return client.create_submission(submissions)
@@ -83,7 +83,7 @@ def get_submissions(
     submissions: Optional[Union[Submission, Submissions]] = None,
     fields: Union[str, Iterable[str], None] = None,
 ) -> Union[Submission, Submissions]:
-    client = resolve_client(client=client, submissions=submissions)
+    client = _resolve_client(client=client, submissions=submissions)
 
     if isinstance(submissions, Submission):
         return client.get_submission(submissions, fields=fields)
@@ -110,7 +110,7 @@ def wait(
     submissions: Optional[Union[Submission, Submissions]] = None,
     retry_mechanism: Optional[RetryMechanism] = None,
 ) -> Union[Submission, Submissions]:
-    client = resolve_client(client, submissions)
+    client = _resolve_client(client, submissions)
 
     if retry_mechanism is None:
         retry_mechanism = RegularPeriodRetry()
@@ -207,7 +207,7 @@ def _execute(
     if source_code is not None:
         submissions = Submission(source_code=source_code, **kwargs)
 
-    client = resolve_client(client=client, submissions=submissions)
+    client = _resolve_client(client=client, submissions=submissions)
     all_submissions = create_submissions_from_test_cases(submissions, test_cases)
     all_submissions = create_submissions(client=client, submissions=all_submissions)
 
diff --git a/tests/test_api.py b/tests/test_api.py
@@ -2,7 +2,7 @@
 import pytest
 
 from judge0 import Flavor, LanguageAlias, Submission
-from judge0.api import resolve_client
+from judge0.api import _resolve_client
 
 DEFAULT_CLIENTS = (
     "atd_ce_client",
@@ -17,7 +17,7 @@
 @pytest.mark.parametrize("client", DEFAULT_CLIENTS)
 def test_resolve_client_with_explicit_client(client, request):
     client = request.getfixturevalue(client)
-    assert resolve_client(client) is client
+    assert _resolve_client(client) is client
 
 
 @pytest.mark.parametrize(
@@ -38,7 +38,7 @@ def test_resolve_client_with_flavor(
     expected_client,
 ):
     # We have to use getattr since both implicit clients are initially None.
-    assert resolve_client(client=flavor) is getattr(judge0, expected_client)
+    assert _resolve_client(client=flavor) is getattr(judge0, expected_client)
 
 
 @pytest.mark.parametrize(
@@ -51,7 +51,7 @@ def test_resolve_client_with_flavor(
 @pytest.mark.skip
 def test_resolve_client_empty_submissions_argument(submissions):
     with pytest.raises(ValueError):
-        resolve_client(submissions=submissions)
+        _resolve_client(submissions=submissions)
 
 
 def test_resolve_client_no_common_client_for_submissions():
@@ -68,7 +68,7 @@ def test_resolve_client_no_common_client_for_submissions():
     submissions = [cpp_submission, py_submission]
 
     with pytest.raises(RuntimeError):
-        resolve_client(submissions=submissions)
+        _resolve_client(submissions=submissions)
 
 
 def test_resolve_client_common_ce_client():
@@ -84,7 +84,7 @@ def test_resolve_client_common_ce_client():
 
     submissions = [cpp_submission, py_submission]
 
-    assert resolve_client(submissions=submissions) is judge0.JUDGE0_IMPLICIT_CE_CLIENT
+    assert _resolve_client(submissions=submissions) is judge0.JUDGE0_IMPLICIT_CE_CLIENT
 
 
 def test_resolve_client_common_extra_ce_client():
@@ -101,6 +101,6 @@ def test_resolve_client_common_extra_ce_client():
     submissions = [cpp_submission, py_submission]
 
     assert (
-        resolve_client(submissions=submissions)
+        _resolve_client(submissions=submissions)
         is judge0.JUDGE0_IMPLICIT_EXTRA_CE_CLIENT
     )
