fix: shell detection message always outputed when generating completion (clearloop#131)

Subjective · web-flow · commit 05e1880e5c6b · 2023-09-09T23:37:26.000+08:00
* fix: shell detection message always outputed when generating completion

* Remove shell detection message

* Update README
diff --git a/README.md b/README.md
@@ -37,6 +37,8 @@ You may also obtain specific shell configuration using.
 leetcode completions fish
 ```
 
+If no argument is provided, the shell is inferred from the `SHELL` environment variable.
+
 </details>
 
 ## Usage
diff --git a/src/cmds/completions.rs b/src/cmds/completions.rs
@@ -51,10 +51,7 @@ fn get_completions_string<G: Generator>(gen: G, cmd: &mut ClapCommand) -> Result
 pub fn completion_handler(m: &ArgMatches, cmd: &mut ClapCommand) -> Result<(), Error> {
     let shell = *m.get_one::<Shell>("shell").unwrap_or(
         // if shell value is not provided try to get from the environment
-        {
-            println!("# Since shell arg value is not provided trying to get the default shell from the environment.");
-            &Shell::from_env().ok_or(Error::MatchError)?
-        }
+        &Shell::from_env().ok_or(Error::MatchError)?,
     );
     let completions = get_completions_string(shell, cmd)?;
     println!("{}", completions);
