Skip to content

Commit 0d93392

Browse files
xyzzy42dpgeorge
authored andcommitted
py/mkrules.mk: List hash files as byproducts.
These are produced by the "cat" command to makeqstrdefs.py, to allow it to not update unchanged files. cmake doesn't know about them and so they are not removed on a "clean". This triggered a bug in makeqstrdefs.py where it would not recreate a deleted output file (which is removed by clean) if a stale hash file with a valid hash still existed. Listing them as byproducts will cause them to be deleted on clean. Signed-off-by: Trent Piepho <tpiepho@gmail.com>
1 parent 85c0216 commit 0d93392

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

py/mkrules.cmake

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ add_custom_command(
9999
add_custom_command(
100100
OUTPUT ${MICROPY_QSTRDEFS_COLLECTED}
101101
COMMAND ${Python3_EXECUTABLE} ${MICROPY_PY_DIR}/makeqstrdefs.py cat qstr _ ${MICROPY_GENHDR_DIR}/qstr ${MICROPY_QSTRDEFS_COLLECTED}
102+
BYPRODUCTS "${MICROPY_QSTRDEFS_COLLECTED}.hash"
102103
DEPENDS ${MICROPY_QSTRDEFS_SPLIT}
103104
VERBATIM
104105
COMMAND_EXPAND_LISTS
@@ -136,6 +137,7 @@ add_custom_command(
136137
add_custom_command(
137138
OUTPUT ${MICROPY_MODULEDEFS_COLLECTED}
138139
COMMAND ${Python3_EXECUTABLE} ${MICROPY_PY_DIR}/makeqstrdefs.py cat module _ ${MICROPY_GENHDR_DIR}/module ${MICROPY_MODULEDEFS_COLLECTED}
140+
BYPRODUCTS "${MICROPY_MODULEDEFS_COLLECTED}.hash"
139141
DEPENDS ${MICROPY_MODULEDEFS_SPLIT}
140142
VERBATIM
141143
COMMAND_EXPAND_LISTS
@@ -161,6 +163,7 @@ add_custom_command(
161163
add_custom_command(
162164
OUTPUT ${MICROPY_ROOT_POINTERS_COLLECTED}
163165
COMMAND ${Python3_EXECUTABLE} ${MICROPY_PY_DIR}/makeqstrdefs.py cat root_pointer _ ${MICROPY_GENHDR_DIR}/root_pointer ${MICROPY_ROOT_POINTERS_COLLECTED}
166+
BYPRODUCTS "${MICROPY_ROOT_POINTERS_COLLECTED}.hash"
164167
DEPENDS ${MICROPY_ROOT_POINTERS_SPLIT}
165168
VERBATIM
166169
COMMAND_EXPAND_LISTS

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy