fix(error): change handle error

steven.roulleau · steven.roulleau · commit 3aa36fdebd2f · 2018-12-21T15:44:49.000+01:00
diff --git a/examples/non-version-specific/handle_errors.html b/examples/non-version-specific/handle_errors.html
@@ -23,10 +23,12 @@
       <div id="editor" touch-action="none"></div>
     </div>
     <script>
-      var editorElement = document.getElementById('editor');
+      const editorElement = document.getElementById('editor');
 
-      editorElement.addEventListener('error', function (evt) {
-        document.querySelector('#result').innerText = JSON.stringify(evt.detail);
+      editorElement.addEventListener('error', (evt) => {
+        if(evt.detail && evt.detail.type !== 'close') {
+          document.querySelector('#result').innerText = JSON.stringify(evt.detail);
+        }
       });
 
       /**
diff --git a/src/Editor.js b/src/Editor.js
@@ -189,17 +189,20 @@ function recognizerCallback(editor, error, model, ...events) {
       } else if (err.message === 'Session is too old. Max Session Duration Reached' ||
         (err.code && err.code === 'session.too.old')) {
         editorRef.error.innerText = Constants.Error.TOO_OLD;
-      } else if ((err.message || err.code === 1006) && editorRef.error.style.display === 'none') {
+      } else if ((err.code === 1006 || err.code === 1000) && editorRef.error.style.display === 'none') {
         editorRef.error.innerText = Constants.Error.NOT_REACHABLE;
       }
-      if ((editorRef.error.innerText === Constants.Error.TOO_OLD || err.code === 1000 || err.reason === 'CLOSE_RECOGNIZER') && RecognizerContext.canReconnect(editor.recognizerContext)) {
+      if ((editorRef.error.innerText === Constants.Error.TOO_OLD || err.reason === 'CLOSE_RECOGNIZER') && RecognizerContext.canReconnect(editor.recognizerContext)) {
         logger.info('Reconnection is available', err.stack || err);
         editorRef.error.style.display = 'none';
       } else {
         editorRef.error.style.display = 'initial';
         triggerCallbacks(editor, err, Constants.EventType.ERROR, ...types);
       }
     } else {
+      if (editorRef.error.style.display === 'initial') {
+        editorRef.error.style.display = 'none';
+      }
       manageRecognizedModel(editorRef, res, ...[...events, ...types].filter((el, i, a) => i === a.indexOf(el))); // Remove duplicate events
     }
   };
