fix(android): race condition on offBackgroundColor view change detection (#9922)

NathanWalker · NathanWalker · commit 464ea18737dc · 2022-06-20T07:20:10.000-07:00
diff --git a/packages/core/ui/switch/index.android.ts b/packages/core/ui/switch/index.android.ts
@@ -57,11 +57,13 @@ export class Switch extends SwitchBase {
 	}
 
 	private setNativeBackgroundColor(value: string | number | Color) {
-		if (value instanceof Color) {
-			// todo: use https://developer.android.com/reference/androidx/core/graphics/BlendModeColorFilterCompat
-			this.nativeViewProtected.getTrackDrawable().setColorFilter(value.android, android.graphics.PorterDuff.Mode.SRC_OVER);
-		} else {
-			this.nativeViewProtected.getTrackDrawable().clearColorFilter();
+		if (this.nativeViewProtected) {
+			if (value instanceof Color) {
+				// todo: use https://developer.android.com/reference/androidx/core/graphics/BlendModeColorFilterCompat
+				this.nativeViewProtected.getTrackDrawable().setColorFilter(value.android, android.graphics.PorterDuff.Mode.SRC_OVER);
+			} else {
+				this.nativeViewProtected.getTrackDrawable().clearColorFilter();
+			}
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -57,11 +57,13 @@ export class Switch extends SwitchBase {`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`private setNativeBackgroundColor(value: string \| number \| Color) {`
`60`		`- if (value instanceof Color) {`
`61`		`- // todo: use https://developer.android.com/reference/androidx/core/graphics/BlendModeColorFilterCompat`
`62`		`- this.nativeViewProtected.getTrackDrawable().setColorFilter(value.android, android.graphics.PorterDuff.Mode.SRC_OVER);`
`63`		`- } else {`
`64`		`- this.nativeViewProtected.getTrackDrawable().clearColorFilter();`
	`60`	`+ if (this.nativeViewProtected) {`
	`61`	`+ if (value instanceof Color) {`
	`62`	`+ // todo: use https://developer.android.com/reference/androidx/core/graphics/BlendModeColorFilterCompat`
	`63`	`+ this.nativeViewProtected.getTrackDrawable().setColorFilter(value.android, android.graphics.PorterDuff.Mode.SRC_OVER);`
	`64`	`+ } else {`
	`65`	`+ this.nativeViewProtected.getTrackDrawable().clearColorFilter();`
	`66`	`+ }`
`65`	`67`	`}`
`66`	`68`	`}`
`67`	`69`