From 25c3d67ff92980b45326a4cc5043561bba393598 Mon Sep 17 00:00:00 2001 From: Jason Cassidy <47318351+jcassidyav@users.noreply.github.com> Date: Tue, 20 Aug 2024 21:09:40 +0100 Subject: [PATCH 1/3] fix: typings path separator on windows (#5812) --- lib/commands/typings.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/commands/typings.ts b/lib/commands/typings.ts index 6856a28378..67f01cfc62 100644 --- a/lib/commands/typings.ts +++ b/lib/commands/typings.ts @@ -77,7 +77,7 @@ export class TypingsCommand implements ICommand { } const items = res.map((item) => { - const [group, artifact, version, sha1, file] = item.split("/"); + const [group, artifact, version, sha1, file] = item.split(path.sep); return { id: sha1 + version, group, From 823565e95102343449bc687387d43a5f223390b1 Mon Sep 17 00:00:00 2001 From: Eduardo Speroni Date: Wed, 28 Aug 2024 09:13:36 -0300 Subject: [PATCH 2/3] fix: don't quote executable in windows --- lib/base-package-manager.ts | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/lib/base-package-manager.ts b/lib/base-package-manager.ts index 86e40c8ea9..12b24df7d1 100644 --- a/lib/base-package-manager.ts +++ b/lib/base-package-manager.ts @@ -1,4 +1,4 @@ -import { isInteractive, quoteString } from "./common/helpers"; +import { isInteractive } from "./common/helpers"; import { INodePackageManager, INodePackageManagerInstallOptions, @@ -108,19 +108,11 @@ export abstract class BasePackageManager implements INodePackageManager { ): Promise { const npmExecutable = this.getPackageManagerExecutableName(); const stdioValue = isInteractive() ? "inherit" : "pipe"; - const sanitizedNpmExecutable = this.$hostInfo.isWindows - ? quoteString(npmExecutable) - : npmExecutable; - await this.$childProcess.spawnFromEvent( - sanitizedNpmExecutable, - params, - "close", - { - cwd: opts.cwd, - stdio: stdioValue, - shell: this.$hostInfo.isWindows, - } - ); + await this.$childProcess.spawnFromEvent(npmExecutable, params, "close", { + cwd: opts.cwd, + stdio: stdioValue, + shell: this.$hostInfo.isWindows, + }); // Whenever calling "npm install" or "yarn add" without any arguments (hence installing all dependencies) no output is emitted on stdout // Luckily, whenever you call "npm install" or "yarn add" to install all dependencies chances are you won't need the name/version of the package you're installing because there is none. From bf0e6202d1c82d7b24e0db928fe033aad4b14760 Mon Sep 17 00:00:00 2001 From: Igor Randjelovic Date: Wed, 28 Aug 2024 14:32:50 +0200 Subject: [PATCH 3/3] release: 8.8.2 --- CHANGELOG.md | 10 ++++++++++ package.json | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7c9ff90782..2d0f157aeb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,13 @@ +## [8.8.2](https://github.com/NativeScript/nativescript-cli/compare/v8.8.1...v8.8.2) (2024-08-28) + + +### Bug Fixes + +* don't quote executable in windows ([823565e](https://github.com/NativeScript/nativescript-cli/commit/823565e95102343449bc687387d43a5f223390b1)) +* typings path separator on windows ([#5812](https://github.com/NativeScript/nativescript-cli/issues/5812)) ([25c3d67](https://github.com/NativeScript/nativescript-cli/commit/25c3d67ff92980b45326a4cc5043561bba393598)) + + + ## [8.8.1](https://github.com/NativeScript/nativescript-cli/compare/v8.8.0...v8.8.1) (2024-08-19) diff --git a/package.json b/package.json index 75f6cbcaa4..83623f43ee 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "nativescript", "main": "./lib/nativescript-cli-lib.js", - "version": "8.8.1", + "version": "8.8.2", "author": "NativeScript ", "description": "Command-line interface for building NativeScript projects", "bin": { pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy