【fix】修复mapboxgl themelayer 关闭事件报错、失败的问题 review by luoxiao

songyumeng · songyumeng · commit 35233e4e0fcb · 2021-07-22T15:10:10.000+08:00
diff --git a/src/mapboxgl/overlay/theme/ThemeLayer.js b/src/mapboxgl/overlay/theme/ThemeLayer.js
@@ -372,7 +372,7 @@ export class Theme {
     off(event, callback, context) { // eslint-disable-line no-unused-vars
         var me = this;
         if (me.renderer) {
-            me.renderer.off(event, callback);
+            me.renderer.un(event, callback);
         } else {
             this.map.off(event, callback);
         }
diff --git a/test/mapboxgl/overlay/RangeThemeLayerSpec.js b/test/mapboxgl/overlay/RangeThemeLayerSpec.js
@@ -431,6 +431,8 @@ describe('mapboxgl_RangeThemeLayer', () => {
                         expect(1).not.toBeNull();
                     }
                     themeLayer.clear();
+                    themeLayer.on('mousemove',function(){});
+                    themeLayer.off('mousemove')
                     done();
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -372,7 +372,7 @@ export class Theme {`
`372`	`372`	`off(event, callback, context) { // eslint-disable-line no-unused-vars`
`373`	`373`	`var me = this;`
`374`	`374`	`if (me.renderer) {`
`375`		`- me.renderer.off(event, callback);`
	`375`	`+ me.renderer.un(event, callback);`
`376`	`376`	`} else {`
`377`	`377`	`this.map.off(event, callback);`
`378`	`378`	`}`
Original file line number	Diff line number	Diff line change
`@@ -431,6 +431,8 @@ describe('mapboxgl_RangeThemeLayer', () => {`
`431`	`431`	`expect(1).not.toBeNull();`
`432`	`432`	`}`
`433`	`433`	`themeLayer.clear();`
	`434`	`+ themeLayer.on('mousemove',function(){});`
	`435`	`+ themeLayer.off('mousemove')`
`434`	`436`	`done();`
`435`	`437`	`}`
`436`	`438`	`}`