Skip to content

feat: add mouse shortcuts to column headers #7268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ntcho
Copy link

@ntcho ntcho commented Apr 18, 2025

Resolves #6282

Changes proposed in this pull request:

  • Add double click mouse shortcut to open column renaming dialog
  • Add right click mouse shortcut to open column menu
  • Add middle click mouse shortcut to collapse column

Functionally it makes sense, but I think there should be a better visual clue that the shortcut exists.

Also the code for dblclick is duplicated from the later part of the file, I think there should be a better way to refactor it too.

@github-actions github-actions bot added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. labels Apr 18, 2025
@SoryRawyer SoryRawyer self-requested a review April 21, 2025 14:20
@magdmartin
Copy link
Member

@ntcho thanks for the PR. I haven't compiled and reviewed the changes, but I'm curious about how you are addressing the discoverability concerns raised in #6282.

@ntcho
Copy link
Author

ntcho commented Apr 24, 2025

My current idea is having a muted text within the menu item describing the shortcut. For example:

[ICON] Rename column [ double click ]
[ICON] Collapse column [ middle click ]

I’ll look into some UI patterns for this and share a simple mockup here.

@SoryRawyer
Copy link
Member

Hey @ntcho, I just wanted to check in and see if you had any questions about the mock-ups or if you were waiting on anything from either me or @magdmartin. Aside from the discoverability component, I think this is ready to move out of draft status.

@ntcho
Copy link
Author

ntcho commented May 2, 2025

image

This is how I'm envisioning showing the shortcut (the Alt + Click shortcut is just an example for the hint, not an actuao shortcut).

Alternatively, we can consider pure icon hints like this to reduce i18n work:

@magdmartin
Copy link
Member

magdmartin commented Jun 12, 2025

Circling back on this PR since it greatly improves the user experience. 

After review, I think it is best not to introduce a new icon in the drop-down menu. We're currently moving toward a consistent use of icons to indicate the type of action a menu item will perform. Adding a new visual element with a different meaning could confuse users and reduce UI consistency.

Instead, as suggested in @tfmorris's comment, I propose highlighting the header in yellow on mouse hover, similar to the existing behavior for the project name.

The tooltip in our case can be double click to rename column

image

Additionally, we'll need to assess how this PR interacts with the column drag-and-drop functionality introduced in #7301 to ensure compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving renaming columns
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy