Validate name in llama stack build (meta-llama#128)

russellb · web-flow · commit fb9e6371eca3 · 2024-09-27T13:30:55.000-07:00
The first time I ran `llama stack build`, I quickly hit enter at the
first prompt asking for a name, assuming it would use the default
given in the help text. This caused a failure later on that wasn't
very obvious. I was using the `docker` format and a blank name caused
an invalid tag format that failed the image build.

This change adds validation for the `name` parameter to ensure it's
not empty before proceeding.

Signed-off-by: Russell Bryant &lt;rbryant@redhat.com&gt;
diff --git a/llama_stack/cli/stack/build.py b/llama_stack/cli/stack/build.py
@@ -199,7 +199,11 @@ def _run_stack_build_command(self, args: argparse.Namespace) -> None:
         if not args.config and not args.template:
             if not args.name:
                 name = prompt(
-                    "> Enter a name for your Llama Stack (e.g. my-local-stack): "
+                    "> Enter a name for your Llama Stack (e.g. my-local-stack): ",
+                    validator=Validator.from_callable(
+                        lambda x: len(x) > 0,
+                        error_message="Name cannot be empty, please enter a name",
+                    ),
                 )
             else:
                 name = args.name
