fix: use a single point for test setup and assertion

RobertByrnes · RobertByrnes · commit 7c96cc4edd06 · 2023-05-17T20:52:37.000+01:00
diff --git a/test/test_client.h b/test/test_client.h
@@ -2,6 +2,8 @@
 
 namespace ClientTest
 {
+    const char * localhost = "localhost";
+
     class MyService
     {
         public:
@@ -30,7 +32,7 @@ namespace ClientTest
         Client* client = ArduinoFakeMock(Client);
 
         TEST_ASSERT_EQUAL(0, client->connected());
-        TEST_ASSERT_EQUAL(1, client->connect("localhost", 8080));
+        TEST_ASSERT_EQUAL(1, client->connect(localhost, 8080));
         TEST_ASSERT_EQUAL(1, client->connected());
         TEST_ASSERT_EQUAL(2, client->peek());
 
@@ -41,7 +43,7 @@ namespace ClientTest
         Verify(Method(ArduinoFake(Client), peek)).Once();
         Verify(Method(ArduinoFake(Client), flush)).Once();
         Verify(Method(ArduinoFake(Client), connected)).Exactly(2_Times);
-        Verify(OverloadedMethod(ArduinoFake(Client), connect, int(const char*, uint16_t)).Using("localhost", 8080)).Once();
+        Verify(OverloadedMethod(ArduinoFake(Client), connect, int(const char*, uint16_t)).Using(localhost, 8080)).Once();
     }
 
     void test_connect(void)
@@ -54,14 +56,14 @@ namespace ClientTest
 
         Client* client = ArduinoFakeMock(Client);
 
-        TEST_ASSERT_EQUAL(1, client->connect("localhost", 8080));
-        TEST_ASSERT_EQUAL(0, client->connect("localhost", 80));
+        TEST_ASSERT_EQUAL(1, client->connect(localhost, 8080));
+        TEST_ASSERT_EQUAL(0, client->connect(localhost, 80));
 
         TEST_ASSERT_EQUAL(0, client->connect(ipAddress1, 8080));
         TEST_ASSERT_EQUAL(1, client->connect(ipAddress2, 8080));
 
-        Verify(OverloadedMethod(ArduinoFake(Client), connect, int(const char*, uint16_t)).Using("localhost", 8080)).Once();
-        Verify(OverloadedMethod(ArduinoFake(Client), connect, int(const char*, uint16_t)).Using("localhost", 80)).Once();
+        Verify(OverloadedMethod(ArduinoFake(Client), connect, int(const char*, uint16_t)).Using(localhost, 8080)).Once();
+        Verify(OverloadedMethod(ArduinoFake(Client), connect, int(const char*, uint16_t)).Using(localhost, 80)).Once();
 
         Verify(OverloadedMethod(ArduinoFake(Client), connect, int(IPAddress, uint16_t)).Using(ipAddress1, 8080)).Once();
         Verify(OverloadedMethod(ArduinoFake(Client), connect, int(IPAddress, uint16_t)).Using(ipAddress2, 8080)).Once();
