merge: reduce upper & lower & add export default (TheAlgorithms#960)

fahimfaisaal · web-flow · commit 27ae62e5c9c6 · 2022-03-28T14:59:21.000+05:30
diff --git a/String/Lower.js b/String/Lower.js
@@ -12,12 +12,9 @@ const lower = (str) => {
     throw new TypeError('Invalid Input Type')
   }
 
-  return str
-    .replace(/[A-Z]/g, (_, indexOfUpperChar) => {
-      const asciiCode = str.charCodeAt(indexOfUpperChar)
-
-      return String.fromCharCode(asciiCode + 32)
-    })
+  return str.replace(
+    /[A-Z]/g, (char) => String.fromCharCode(char.charCodeAt() + 32)
+  )
 }
 
-export { lower }
+export default lower
diff --git a/String/Upper.js b/String/Upper.js
@@ -12,13 +12,8 @@ const upper = (str) => {
   }
 
   return str.replace(
-    /[a-z]/g,
-    (_, indexOfLowerChar) => {
-      const asciiCode = str.charCodeAt(indexOfLowerChar)
-
-      return String.fromCharCode(asciiCode - 32)
-    }
+    /[a-z]/g, (char) => String.fromCharCode(char.charCodeAt() - 32)
   )
 }
 
-export { upper }
+export default upper
diff --git a/String/test/Lower.test.js b/String/test/Lower.test.js
@@ -1,4 +1,4 @@
-import { lower } from '../Lower'
+import lower from '../Lower'
 
 describe('Testing the Lower function', () => {
   it('Test 1: Check by invalid type', () => {
diff --git a/String/test/Upper.test.js b/String/test/Upper.test.js
@@ -1,6 +1,6 @@
-import { upper } from '../Upper'
+import upper from '../Upper'
 
-describe('Upper', () => {
+describe('Testing the Upper function', () => {
   it('return uppercase strings', () => {
     expect(upper('hello')).toBe('HELLO')
     expect(upper('WORLD')).toBe('WORLD')

Original file line number	Diff line number	Diff line change
`@@ -12,13 +12,8 @@ const upper = (str) => {`
`12`	`12`	`}`
`13`	`13`
`14`	`14`	`return str.replace(`
`15`		`- /[a-z]/g,`
`16`		`- (_, indexOfLowerChar) => {`
`17`		`- const asciiCode = str.charCodeAt(indexOfLowerChar)`
`18`		`-`
`19`		`- return String.fromCharCode(asciiCode - 32)`
`20`		`- }`
	`15`	`+ /[a-z]/g, (char) => String.fromCharCode(char.charCodeAt() - 32)`
`21`	`16`	`)`
`22`	`17`	`}`
`23`	`18`
`24`		`-export { upper }`
	`19`	`+export default upper`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { lower } from '../Lower'`
	`1`	`+import lower from '../Lower'`
`2`	`2`
`3`	`3`	`describe('Testing the Lower function', () => {`
`4`	`4`	`it('Test 1: Check by invalid type', () => {`